Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] fix overlayfs support on rocky 9.4 #31948

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

paulcacheux
Copy link
Contributor

@paulcacheux paulcacheux commented Dec 10, 2024

What does this PR do?

This PR fixes the support of overlayfs filesystem on rocky 9.4 and it's 5.14+patch kernel. It turns out a pretty recent kernel patch was backported so this PR updates the detection mechanism to apply the code supporting this patch to this old kernel on rocky 9.4.

This PR also includes a small fix for the offset of dentry.d_sb that is different on this specific kernel as well.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@paulcacheux paulcacheux force-pushed the paulcacheux/rocky9.4-ovl-fix branch from 8820ed0 to c55b11c Compare December 10, 2024 08:10
@paulcacheux paulcacheux changed the title Paulcacheux/rocky9.4 ovl fix [CWS] fix overlayfs support on rocky 9.4 Dec 10, 2024
@paulcacheux paulcacheux added changelog/no-changelog qa/done QA done before merge and regressions are covered by tests labels Dec 10, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 10, 2024

Package size comparison

Comparison with ancestor f0211e154ff254b01a16d09a8f770c2536a8c9c4

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.02MB ⚠️ 1270.70MB 1270.67MB 140.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.20MB 113.20MB 10.00MB
datadog-dogstatsd-amd64-deb 0.00MB 78.32MB 78.32MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 526.45MB 526.45MB 70.00MB
datadog-agent-x86_64-rpm 0.02MB ⚠️ 1279.93MB 1279.91MB 140.00MB
datadog-agent-x86_64-suse 0.02MB ⚠️ 1279.93MB 1279.91MB 140.00MB
datadog-iot-agent-x86_64-rpm 0.00MB ⚠️ 113.26MB 113.26MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB ⚠️ 113.26MB 113.26MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 78.40MB 78.40MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 78.40MB 78.40MB 10.00MB
datadog-agent-arm64-deb 0.04MB ⚠️ 1004.88MB 1004.85MB 140.00MB
datadog-iot-agent-arm64-deb 0.00MB 108.67MB 108.67MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 55.59MB 55.59MB 10.00MB
datadog-agent-aarch64-rpm 0.04MB ⚠️ 1014.10MB 1014.06MB 140.00MB
datadog-iot-agent-aarch64-rpm -0.00MB 108.74MB 108.74MB 10.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 10, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50714093 --os-family=ubuntu

Note: This applies to commit 9bbe370

Copy link

cit-pr-commenter bot commented Dec 10, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: e106c34d-aa73-4648-9e0e-cd38dfe6f9f9

Baseline: f0211e1
Comparison: 9bbe370
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +1.57 [-1.37, +4.52] 1 Logs
otel_to_otel_logs ingress throughput +0.67 [-0.06, +1.40] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.47 [+0.42, +0.53] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.16 [-0.47, +0.79] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput +0.02 [-0.87, +0.91] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.10, +0.07] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.03 [-0.86, +0.80] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.06 [-0.74, +0.61] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.07 [-0.86, +0.73] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.09 [-0.56, +0.38] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.09 [-0.86, +0.68] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.34 [-1.11, +0.43] 1 Logs
quality_gate_idle memory utilization -0.69 [-0.74, -0.64] 1 Logs bounds checks dashboard
file_tree memory utilization -0.94 [-1.06, -0.82] 1 Logs
quality_gate_idle_all_features memory utilization -1.30 [-1.43, -1.17] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization -1.51 [-2.24, -0.79] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@paulcacheux paulcacheux force-pushed the paulcacheux/rocky9.4-ovl-fix branch 3 times, most recently from 4bab94e to a4c4a47 Compare December 10, 2024 12:58
@paulcacheux paulcacheux marked this pull request as ready for review December 10, 2024 13:34
@paulcacheux paulcacheux requested a review from a team as a code owner December 10, 2024 13:34
@paulcacheux paulcacheux force-pushed the paulcacheux/rocky9.4-ovl-fix branch from 5584c18 to 9bbe370 Compare December 10, 2024 15:01
@paulcacheux
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 10, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-10 15:46:54 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-12-10 16:04:26 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 24m.

@dd-mergequeue dd-mergequeue bot merged commit b92624a into main Dec 10, 2024
229 of 230 checks passed
@dd-mergequeue dd-mergequeue bot deleted the paulcacheux/rocky9.4-ovl-fix branch December 10, 2024 16:31
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants