-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 7.61.x] Query Aurora instances per cluster #31853
Conversation
(cherry picked from commit d255f0c)
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=50483711 --os-family=ubuntu Note: This applies to commit 675c35e |
/merge |
Devflow running:
|
[Fast Unit Tests Report] On pipeline 50483711 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: ed82389 Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | basic_py_check | % cpu utilization | +1.68 | [-2.23, +5.60] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.41 | [-0.39, +1.20] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | +0.28 | [+0.24, +0.33] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.26 | [-0.21, +0.73] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | +0.15 | [-0.48, +0.79] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.02, +0.01] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.00 | [-0.76, +0.75] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.01 | [-0.11, +0.10] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.06 | [-0.90, +0.77] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.09 | [-0.81, +0.63] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.13 | [-0.76, +0.50] | 1 | Logs |
➖ | file_tree | memory utilization | -0.23 | [-0.39, -0.07] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.28 | [-0.34, -0.23] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | -0.30 | [-1.07, +0.47] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -0.46 | [-0.58, -0.35] | 1 | Logs bounds checks dashboard |
➖ | pycheck_lots_of_tags | % cpu utilization | -0.71 | [-4.08, +2.67] | 1 | Logs |
➖ | quality_gate_logs | % cpu utilization | -1.81 | [-4.73, +1.11] | 1 | Logs |
Bounds Checks: ❌ Failed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
❌ | file_to_blackhole_300ms_latency | lost_bytes | 9/10 | |
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | |
✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
/merge |
Devflow running:
|
Backport d255f0c from #31846.
<!--
-->
What does this PR do?
Updates Aurora autodiscovery to query database instances per cluster.
Motivation
DescribeDBInstances
has a limit of 100 instances per call. As a first pass at handling large AWS RDS installations this will allow the agent to autodiscover up to 100 instances per cluster, rather than 100 instances total.Describe how you validated your changes
<!--
Validate your changes before merge, ensuring that:
If you want additional validation by a second person, you can ask reviewers to do it. Describe how to set up an environment for manual tests in the PR description. Manual validation is expected to happen on every commit before merge.
Any manual validation step should then map to an automated test. Manual validation should not substitute automation, minus exceptions not supported by test tooling yet.
-->
Mocked tests have been updated but full confirmation can only be done in a deployment to a customer with a large number of Aurora instances being autodiscovered.
Possible Drawbacks / Trade-offs
Additional Notes
<!--
version was chosen.
-->