(fleet) isolate the downloader in its own sub cmd

[arbll]

This PR:

• Isolates the installer downloader in its own cmd/. It's a separate binary and should be isolated as such (it's also a headache to work with build tags :p)
• Renames bootstrapper => downloader since we're moving all the logic apart from the download portion to the setup
• Cleans up and improves the installer/downloader build logic

Describe how you validated your changes

Those changes are not yet used in prod.

[agent-platform-auto-pr]

Gitlab CI Configuration Changes

Modified Jobs

installer-install-scripts

  installer-install-scripts:
    artifacts:
      expire_in: 2 weeks
      paths:
      - $OMNIBUS_PACKAGE_DIR
    image: registry.ddbuild.io/ci/datadog-agent-buildimages/deb_x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
    needs:
    - go_mod_tidy_check
    - go_deps
    rules:
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - when: on_success
    script:
    - mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache.tar.xz -C $GOPATH/pkg/mod/cache
    - rm -f modcache.tar.xz
    - echo "About to build for $RELEASE_VERSION"
    - mkdir -p $OMNIBUS_PACKAGE_DIR
-   - inv -e installer.build-linux-script && mv ./bin/installer/setup.sh $OMNIBUS_PACKAGE_DIR/install-djm.sh
?                                                                - ^^
+   - inv -e installer.build-linux-script && mv ./bin/installer/install.sh $OMNIBUS_PACKAGE_DIR/install-djm.sh
?                                                               ++  ^^^
    - ls -la $OMNIBUS_PACKAGE_DIR
    stage: package_build
    tags:
    - arch:amd64
    variables:
      KUBERNETES_CPU_REQUEST: 8
      KUBERNETES_MEMORY_LIMIT: 16Gi
      KUBERNETES_MEMORY_REQUEST: 16Gi
      RELEASE_VERSION: $RELEASE_VERSION_7

Changes Summary

Removed	Modified	Added	Renamed
0	1	0	0

ℹ️ Diff available in the job log.

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50427476 --os-family=ubuntu

Note: This applies to commit 77d1036

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 2d401031-f1ca-4dc7-ac4f-a0c1c56a6d43

Baseline: 8592613
Comparison: 77d1036
Diff

❌ Experiments with missing or malformed data

This is a critical error. No usable optimization goal data was produced by the listed experiments. This may be a result of misconfiguration. Ping #single-machine-performance and we can help out.

• tcp_dd_logs_filter_exclude (Logs)

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+0.82	[-2.08, +3.72]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.22	[-0.24, +0.69]	1	Logs
➖	file_tree	memory utilization	+0.16	[+0.02, +0.30]	1	Logs
➖	quality_gate_idle	memory utilization	+0.12	[+0.07, +0.16]	1	Logs bounds checks dashboard
➖	file_to_blackhole_500ms_latency	egress throughput	+0.10	[-0.67, +0.87]	1	Logs
➖	otel_to_otel_logs	ingress throughput	+0.09	[-0.60, +0.79]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.10, +0.10]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.02	[-0.91, +0.87]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.02	[-0.75, +0.72]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.05	[-0.69, +0.58]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.52	[-1.31, +0.27]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	-1.19	[-1.29, -1.09]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	-1.59	[-1.70, -1.47]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.78	[-2.50, -1.06]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	file_to_blackhole_500ms_latency	lost_bytes	9/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[arbll]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2024-12-06 09:17:05 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 23m.