-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASCII-2578] Remove seelog imports outside pkg/util/log #31788
[ASCII-2578] Remove seelog imports outside pkg/util/log #31788
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=50832481 --os-family=ubuntu Note: This applies to commit 42911ae |
abeaf55
to
be45c78
Compare
/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on |
Devflow running:
|
Devflow running:
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: c239913 Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | quality_gate_idle_all_features | memory utilization | +0.88 | [+0.77, +1.00] | 1 | Logs bounds checks dashboard |
➖ | quality_gate_logs | % cpu utilization | +0.86 | [-2.08, +3.80] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | +0.33 | [-0.38, +1.04] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.25 | [-0.54, +1.05] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.14 | [-0.62, +0.90] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.03 | [-0.44, +0.49] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | +0.01 | [-0.62, +0.64] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.09, +0.10] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.05 | [-0.88, +0.78] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | -0.05 | [-0.95, +0.85] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | -0.08 | [-0.12, -0.04] | 1 | Logs bounds checks dashboard |
➖ | file_tree | memory utilization | -0.11 | [-0.23, +0.02] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.11 | [-0.88, +0.66] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | -0.13 | [-0.99, +0.73] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.88 | [-1.60, -0.15] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.89 | [-0.94, -0.84] | 1 | Logs |
Bounds Checks: ✅ Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_logs | lost_bytes | 10/10 | |
✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good for the trace-agent!! Thanks for taking on this work!
…/remove-seelog-outside-pkg-util-log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻 LGTM for file owned by @DataDog/container-integrations.
…/remove-seelog-outside-pkg-util-log
…/remove-seelog-outside-pkg-util-log
/merge |
Devflow running:
|
Serverless Benchmark Results
tl;drUse these benchmarks as an insight tool during development.
What is this benchmarking?The The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type. How do I interpret these charts?The charts below comes from The benchstat docs explain how to interpret these charts.
I need more helpFirst off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development. If you would like a hand interpreting the results come chat with us in Benchmark stats
|
Package size comparisonComparison with ancestor Diff per package
Decision |
What does this PR do?
Remove most direct uses of https://github.com/cihub/seelog outside of
pkg/util/log
(and enforce it with a linter).It does so by creating aliases for constants (log levels), types (
LoggerInterface
), and functions (a few basic functions to create a logger) of seelog inpkg/util/log
.Motivation
Avoid leaking the agent logging abstraction (no code should rely on
seelog
directly, onlypkg/util/log
).This will make it much easier to replace
seelog
with another library.Describe how you validated your changes
There should be no functional change, only aliases, so CI is considered good enough.
Two tests called
seelog.ReplaceLogger
(on top oflog.SetupLogger
), which should not be needed, the PR removes these two calls, this should be the only change in behavior.The two tests are in
comp/trace/config/config_test.go
andpkg/util/kubernetes/apiserver/controllers/wpa_controller_test.go
.Possible Drawbacks / Trade-offs
Additional Notes
https://github.com/cihub/seelog didn't get a single commit in 8 years, it is unmaintained, and we should probably not be using it anymore.
There are a few remaining uses of seelog outside of
pkg/util/log
:cmd/agent/common/common_windows.go
: initialize the logger on Windows with a specific configpkg/process/procutil/process_linux_test.go
: disable logging fromDataDog/gopsutil
pkg/ebpf/ebpftest/log.go
: creating a custom logger for testingpkg/ebpf/ebpftest/fail_log.go
: creating a custom logger for testing