Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASCII-2578] Remove seelog imports outside pkg/util/log #31788

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

pgimalac
Copy link
Member

@pgimalac pgimalac commented Dec 5, 2024

What does this PR do?

Remove most direct uses of https://github.com/cihub/seelog outside of pkg/util/log (and enforce it with a linter).

It does so by creating aliases for constants (log levels), types (LoggerInterface), and functions (a few basic functions to create a logger) of seelog in pkg/util/log.

Motivation

Avoid leaking the agent logging abstraction (no code should rely on seelog directly, only pkg/util/log).
This will make it much easier to replace seelog with another library.

Describe how you validated your changes

There should be no functional change, only aliases, so CI is considered good enough.

Two tests called seelog.ReplaceLogger (on top of log.SetupLogger), which should not be needed, the PR removes these two calls, this should be the only change in behavior.
The two tests are in comp/trace/config/config_test.go and pkg/util/kubernetes/apiserver/controllers/wpa_controller_test.go.

Possible Drawbacks / Trade-offs

Additional Notes

https://github.com/cihub/seelog didn't get a single commit in 8 years, it is unmaintained, and we should probably not be using it anymore.

There are a few remaining uses of seelog outside of pkg/util/log:

  • cmd/agent/common/common_windows.go: initialize the logger on Windows with a specific config
  • pkg/process/procutil/process_linux_test.go: disable logging from DataDog/gopsutil
  • pkg/ebpf/ebpftest/log.go: creating a custom logger for testing
  • pkg/ebpf/ebpftest/fail_log.go: creating a custom logger for testing

@pgimalac pgimalac added changelog/no-changelog team/agent-shared-components qa/done QA done before merge and regressions are covered by tests labels Dec 5, 2024
@github-actions github-actions bot added component/system-probe long review PR is complex, plan time to review it labels Dec 5, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Dec 5, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50832481 --os-family=ubuntu

Note: This applies to commit 42911ae

@pgimalac pgimalac force-pushed the pgimalac/remove-seelog-outside-pkg-util-log branch from abeaf55 to be45c78 Compare December 5, 2024 13:40
@pgimalac
Copy link
Member Author

pgimalac commented Dec 5, 2024

/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

@dd-devflow
Copy link

dd-devflow bot commented Dec 5, 2024

Devflow running: /trigger-ci --variable RUN_ALL_BUILDS=true --varia...

View all feedbacks in Devflow UI.


2024-12-05 13:46:02 UTC ℹ️ Gitlab pipeline started

Started pipeline #50392904

@dd-devflow
Copy link

dd-devflow bot commented Dec 5, 2024

Devflow running: /trigger-ci --variable RUN_ALL_BUILDS=true --varia...

View all feedbacks in Devflow UI.


2024-12-05 13:46:04 UTC ℹ️ Devflow: /trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on

Copy link

cit-pr-commenter bot commented Dec 5, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 164dac40-619d-43af-bcbf-4c0ba25df086

Baseline: c239913
Comparison: 42911ae
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle_all_features memory utilization +0.88 [+0.77, +1.00] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization +0.86 [-2.08, +3.80] 1 Logs
otel_to_otel_logs ingress throughput +0.33 [-0.38, +1.04] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.25 [-0.54, +1.05] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.14 [-0.62, +0.90] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.03 [-0.44, +0.49] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.01 [-0.62, +0.64] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.09, +0.10] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.05 [-0.88, +0.78] 1 Logs
file_to_blackhole_0ms_latency_http1 egress throughput -0.05 [-0.95, +0.85] 1 Logs
quality_gate_idle memory utilization -0.08 [-0.12, -0.04] 1 Logs bounds checks dashboard
file_tree memory utilization -0.11 [-0.23, +0.02] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.11 [-0.88, +0.66] 1 Logs
file_to_blackhole_0ms_latency_http2 egress throughput -0.13 [-0.99, +0.73] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.88 [-1.60, -0.15] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.89 [-0.94, -0.84] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_0ms_latency_http1 lost_bytes 10/10
file_to_blackhole_0ms_latency_http1 memory_usage 10/10
file_to_blackhole_0ms_latency_http2 lost_bytes 10/10
file_to_blackhole_0ms_latency_http2 memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@pgimalac pgimalac marked this pull request as ready for review December 5, 2024 15:30
@pgimalac pgimalac requested review from a team as code owners December 5, 2024 15:30
Copy link
Contributor

@ajgajg1134 ajgajg1134 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good for the trace-agent!! Thanks for taking on this work!

@pgimalac pgimalac removed the request for review from Kaderinho December 6, 2024 13:39
Copy link
Member

@L3n41c L3n41c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 LGTM for file owned by @DataDog/container-integrations.

@pgimalac
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 11, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-11 13:32:51 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-12-11 14:45:44 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 24m.


2024-12-11 16:02:57 UTC ℹ️ MergeQueue: This merge request was merged

Copy link
Contributor

Serverless Benchmark Results

BenchmarkStartEndInvocation comparison between 6d7ae5b and bf1f144.

tl;dr

Use these benchmarks as an insight tool during development.

  1. Skim down the vs base column in each chart. If there is a ~, then there was no statistically significant change to the benchmark. Otherwise, ensure the estimated percent change is either negative or very small.

  2. The last row of each chart is the geomean. Ensure this percentage is either negative or very small.

What is this benchmarking?

The BenchmarkStartEndInvocation compares the amount of time it takes to call the start-invocation and end-invocation endpoints. For universal instrumentation languages (Dotnet, Golang, Java, Ruby), this represents the majority of the duration overhead added by our tracing layer.

The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type.

How do I interpret these charts?

The charts below comes from benchstat. They represent the statistical change in duration (sec/op), memory overhead (B/op), and allocations (allocs/op).

The benchstat docs explain how to interpret these charts.

Before the comparison table, we see common file-level configuration. If there are benchmarks with different configuration (for example, from different packages), benchstat will print separate tables for each configuration.

The table then compares the two input files for each benchmark. It shows the median and 95% confidence interval summaries for each benchmark before and after the change, and an A/B comparison under "vs base". ... The p-value measures how likely it is that any differences were due to random chance (i.e., noise). The "~" means benchstat did not detect a statistically significant difference between the two inputs. ...

Note that "statistically significant" is not the same as "large": with enough low-noise data, even very small changes can be distinguished from noise and considered statistically significant. It is, of course, generally easier to distinguish large changes from noise.

Finally, the last row of the table shows the geometric mean of each column, giving an overall picture of how the benchmarks changed. Proportional changes in the geomean reflect proportional changes in the benchmarks. For example, given n benchmarks, if sec/op for one of them increases by a factor of 2, then the sec/op geomean will increase by a factor of ⁿ√2.

I need more help

First off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development.

If you would like a hand interpreting the results come chat with us in #serverless-agent in the internal DataDog slack or in #serverless in the public DataDog slack. We're happy to help!

Benchmark stats
goos: linux
goarch: amd64
pkg: github.com/DataDog/datadog-agent/pkg/serverless/daemon
cpu: AMD EPYC 7763 64-Core Processor                
                                      │ baseline/benchmark.log │       current/benchmark.log        │
                                      │         sec/op         │   sec/op     vs base               │
api-gateway-appsec.json                            90.52µ ± 2%   89.81µ ± 4%       ~ (p=0.684 n=10)
api-gateway-kong-appsec.json                       72.11µ ± 5%   69.76µ ± 3%       ~ (p=0.105 n=10)
api-gateway-kong.json                              66.83µ ± 2%   66.44µ ± 1%       ~ (p=0.315 n=10)
api-gateway-non-proxy-async.json                   105.6µ ± 2%   105.5µ ± 2%       ~ (p=0.579 n=10)
api-gateway-non-proxy.json                         103.1µ ± 2%   104.3µ ± 1%       ~ (p=0.075 n=10)
api-gateway-websocket-connect.json                 68.47µ ± 2%   68.28µ ± 1%       ~ (p=0.912 n=10)
api-gateway-websocket-default.json                 61.04µ ± 1%   61.06µ ± 2%       ~ (p=0.684 n=10)
api-gateway-websocket-disconnect.json              60.34µ ± 1%   61.00µ ± 0%  +1.10% (p=0.008 n=10)
api-gateway.json                                   111.4µ ± 2%   110.0µ ± 1%  -1.18% (p=0.043 n=10)
application-load-balancer.json                     58.63µ ± 2%   61.18µ ± 2%  +4.35% (p=0.000 n=10)
cloudfront.json                                    44.51µ ± 1%   46.46µ ± 4%  +4.37% (p=0.000 n=10)
cloudwatch-events.json                             37.36µ ± 1%   38.49µ ± 3%  +3.01% (p=0.000 n=10)
cloudwatch-logs.json                               59.77µ ± 2%   63.23µ ± 3%  +5.79% (p=0.000 n=10)
custom.json                                        31.02µ ± 1%   32.25µ ± 1%  +3.98% (p=0.000 n=10)
dynamodb.json                                      84.41µ ± 1%   88.38µ ± 1%  +4.70% (p=0.000 n=10)
empty.json                                         29.13µ ± 1%   30.74µ ± 2%  +5.52% (p=0.000 n=10)
eventbridge-custom.json                            46.29µ ± 8%   48.07µ ± 0%       ~ (p=0.063 n=10)
eventbridge-no-bus.json                            45.65µ ± 4%   46.46µ ± 3%       ~ (p=0.052 n=10)
eventbridge-no-timestamp.json                      45.83µ ± 1%   46.33µ ± 2%       ~ (p=0.075 n=10)
eventbridgesns.json                                59.57µ ± 1%   61.82µ ± 3%  +3.77% (p=0.000 n=10)
eventbridgesqs.json                                64.39µ ± 3%   67.43µ ± 1%  +4.71% (p=0.002 n=10)
http-api.json                                      64.67µ ± 1%   67.73µ ± 2%  +4.73% (p=0.000 n=10)
kinesis-batch.json                                 64.48µ ± 1%   65.93µ ± 2%  +2.25% (p=0.000 n=10)
kinesis.json                                       51.40µ ± 1%   53.85µ ± 1%  +4.76% (p=0.001 n=10)
s3.json                                            55.60µ ± 1%   57.65µ ± 1%  +3.69% (p=0.000 n=10)
sns-batch.json                                     82.35µ ± 2%   85.26µ ± 1%  +3.54% (p=0.000 n=10)
sns.json                                           62.72µ ± 1%   64.92µ ± 1%  +3.52% (p=0.000 n=10)
snssqs.json                                        104.0µ ± 2%   107.8µ ± 1%  +3.65% (p=0.000 n=10)
snssqs_no_dd_context.json                          94.42µ ± 2%   98.30µ ± 1%  +4.11% (p=0.000 n=10)
sqs-aws-header.json                                52.92µ ± 2%   55.67µ ± 2%  +5.19% (p=0.000 n=10)
sqs-batch.json                                     85.05µ ± 1%   90.20µ ± 3%  +6.06% (p=0.000 n=10)
sqs.json                                           63.58µ ± 1%   65.64µ ± 2%  +3.24% (p=0.000 n=10)
sqs_no_dd_context.json                             58.10µ ± 2%   59.18µ ± 1%  +1.85% (p=0.007 n=10)
stepfunction.json                                  41.28µ ± 1%   42.75µ ± 1%  +3.55% (p=0.000 n=10)
geomean                                            62.08µ        63.77µ       +2.72%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │          B/op          │     B/op      vs base               │
api-gateway-appsec.json                           37.26Ki ± 0%   37.33Ki ± 0%  +0.18% (p=0.000 n=10)
api-gateway-kong-appsec.json                      26.91Ki ± 0%   26.91Ki ± 0%       ~ (p=0.639 n=10)
api-gateway-kong.json                             24.37Ki ± 0%   24.37Ki ± 0%       ~ (p=0.423 n=10)
api-gateway-non-proxy-async.json                  47.94Ki ± 0%   48.00Ki ± 0%  +0.11% (p=0.000 n=10)
api-gateway-non-proxy.json                        47.12Ki ± 0%   47.17Ki ± 0%  +0.12% (p=0.000 n=10)
api-gateway-websocket-connect.json                25.34Ki ± 0%   25.37Ki ± 0%  +0.13% (p=0.000 n=10)
api-gateway-websocket-default.json                21.23Ki ± 0%   21.26Ki ± 0%  +0.15% (p=0.000 n=10)
api-gateway-websocket-disconnect.json             20.99Ki ± 0%   21.02Ki ± 0%  +0.14% (p=0.000 n=10)
api-gateway.json                                  49.27Ki ± 0%   49.27Ki ± 0%       ~ (p=0.867 n=10)
application-load-balancer.json                    22.46Ki ± 0%   23.39Ki ± 0%  +4.18% (p=0.000 n=10)
cloudfront.json                                   17.44Ki ± 0%   17.45Ki ± 0%  +0.09% (p=0.000 n=10)
cloudwatch-events.json                            11.49Ki ± 0%   11.52Ki ± 0%  +0.28% (p=0.000 n=10)
cloudwatch-logs.json                              53.05Ki ± 0%   53.05Ki ± 0%  +0.01% (p=0.016 n=10)
custom.json                                       9.528Ki ± 0%   9.545Ki ± 0%  +0.17% (p=0.000 n=10)
dynamodb.json                                     40.30Ki ± 0%   40.33Ki ± 0%  +0.07% (p=0.000 n=10)
empty.json                                        9.067Ki ± 0%   9.083Ki ± 0%  +0.18% (p=0.000 n=10)
eventbridge-custom.json                           14.67Ki ± 0%   14.67Ki ± 0%       ~ (p=0.442 n=10)
eventbridge-no-bus.json                           13.63Ki ± 0%   13.64Ki ± 0%       ~ (p=0.162 n=10)
eventbridge-no-timestamp.json                     13.63Ki ± 0%   13.63Ki ± 0%       ~ (p=0.431 n=10)
eventbridgesns.json                               20.43Ki ± 0%   20.46Ki ± 0%  +0.15% (p=0.000 n=10)
eventbridgesqs.json                               24.56Ki ± 0%   24.59Ki ± 0%  +0.13% (p=0.000 n=10)
http-api.json                                     23.25Ki ± 0%   23.31Ki ± 0%  +0.26% (p=0.000 n=10)
kinesis-batch.json                                26.49Ki ± 0%   26.53Ki ± 0%  +0.12% (p=0.000 n=10)
kinesis.json                                      17.37Ki ± 0%   17.40Ki ± 0%  +0.18% (p=0.000 n=10)
s3.json                                           19.87Ki ± 0%   19.90Ki ± 0%  +0.15% (p=0.000 n=10)
sns-batch.json                                    39.08Ki ± 0%   39.08Ki ± 0%       ~ (p=0.205 n=10)
sns.json                                          24.49Ki ± 0%   24.49Ki ± 0%       ~ (p=0.071 n=10)
snssqs.json                                       52.68Ki ± 0%   52.74Ki ± 0%  +0.12% (p=0.000 n=10)
snssqs_no_dd_context.json                         46.44Ki ± 0%   46.50Ki ± 0%  +0.13% (p=0.000 n=10)
sqs-aws-header.json                               18.78Ki ± 0%   18.78Ki ± 0%       ~ (p=0.443 n=10)
sqs-batch.json                                    41.26Ki ± 0%   41.26Ki ± 0%       ~ (p=0.879 n=10)
sqs.json                                          25.39Ki ± 0%   25.39Ki ± 0%       ~ (p=0.144 n=10)
sqs_no_dd_context.json                            21.01Ki ± 0%   21.04Ki ± 0%  +0.14% (p=0.000 n=10)
stepfunction.json                                 13.51Ki ± 0%   13.54Ki ± 0%  +0.23% (p=0.000 n=10)
geomean                                           24.10Ki        24.15Ki       +0.22%

                                      │ baseline/benchmark.log │        current/benchmark.log        │
                                      │       allocs/op        │ allocs/op   vs base                 │
api-gateway-appsec.json                             630.0 ± 0%   630.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-kong-appsec.json                        488.0 ± 0%   488.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-kong.json                               466.0 ± 0%   466.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-non-proxy-async.json                    723.0 ± 0%   723.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-non-proxy.json                          713.0 ± 0%   713.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-websocket-connect.json                  451.0 ± 0%   451.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-websocket-default.json                  376.0 ± 0%   376.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway-websocket-disconnect.json               366.0 ± 0%   366.0 ± 0%       ~ (p=1.000 n=10) ¹
api-gateway.json                                    785.0 ± 0%   785.0 ± 0%       ~ (p=1.000 n=10) ¹
application-load-balancer.json                      350.0 ± 0%   351.0 ± 0%  +0.29% (p=0.000 n=10)
cloudfront.json                                     281.0 ± 0%   281.0 ± 0%       ~ (p=1.000 n=10) ¹
cloudwatch-events.json                              218.0 ± 0%   218.0 ± 0%       ~ (p=1.000 n=10) ¹
cloudwatch-logs.json                                211.0 ± 0%   211.0 ± 0%       ~ (p=1.000 n=10) ¹
custom.json                                         166.0 ± 0%   166.0 ± 0%       ~ (p=1.000 n=10) ¹
dynamodb.json                                       582.0 ± 0%   582.0 ± 0%       ~ (p=1.000 n=10) ¹
empty.json                                          157.0 ± 0%   157.0 ± 0%       ~ (p=1.000 n=10) ¹
eventbridge-custom.json                             261.0 ± 0%   261.0 ± 0%       ~ (p=1.000 n=10) ¹
eventbridge-no-bus.json                             252.0 ± 0%   252.0 ± 0%       ~ (p=1.000 n=10) ¹
eventbridge-no-timestamp.json                       252.0 ± 0%   252.0 ± 0%       ~ (p=1.000 n=10) ¹
eventbridgesns.json                                 318.0 ± 0%   318.0 ± 0%       ~ (p=1.000 n=10) ¹
eventbridgesqs.json                                 358.0 ± 0%   358.0 ± 0%       ~ (p=1.000 n=10) ¹
http-api.json                                       424.0 ± 0%   424.0 ± 0%       ~ (p=1.000 n=10) ¹
kinesis-batch.json                                  383.0 ± 0%   383.0 ± 0%       ~ (p=1.000 n=10) ¹
kinesis.json                                        279.0 ± 0%   279.0 ± 0%       ~ (p=1.000 n=10) ¹
s3.json                                             351.0 ± 0%   351.0 ± 0%       ~ (p=1.000 n=10) ¹
sns-batch.json                                      465.0 ± 0%   465.0 ± 0%       ~ (p=1.000 n=10) ¹
sns.json                                            336.0 ± 0%   336.0 ± 0%       ~ (p=1.000 n=10) ¹
snssqs.json                                         460.0 ± 0%   460.0 ± 0%       ~ (p=1.000 n=10) ¹
snssqs_no_dd_context.json                           420.0 ± 0%   420.0 ± 0%       ~ (p=1.000 n=10) ¹
sqs-aws-header.json                                 276.0 ± 0%   276.0 ± 0%       ~ (p=1.000 n=10) ¹
sqs-batch.json                                      500.0 ± 0%   500.0 ± 0%       ~ (p=1.000 n=10) ¹
sqs.json                                            351.0 ± 0%   351.0 ± 0%       ~ (p=1.000 n=10) ¹
sqs_no_dd_context.json                              337.0 ± 0%   337.0 ± 0%       ~ (p=1.000 n=10) ¹
stepfunction.json                                   226.0 ± 0%   226.0 ± 0%       ~ (p=1.000 n=10) ¹
geomean                                             360.1        360.1       +0.01%
¹ all samples are equal

@agent-platform-auto-pr
Copy link
Contributor

Package size comparison

Comparison with ancestor c23991318bdae9f2137171b7d8d44e7753d2e346

Diff per package
package diff status size ancestor threshold
datadog-agent-amd64-deb 0.02MB ⚠️ 1271.36MB 1271.34MB 140.00MB
datadog-iot-agent-amd64-deb -0.01MB 113.21MB 113.22MB 10.00MB
datadog-dogstatsd-amd64-deb -0.00MB 78.33MB 78.33MB 10.00MB
datadog-heroku-agent-amd64-deb -0.01MB 526.48MB 526.49MB 70.00MB
datadog-agent-x86_64-rpm 0.02MB ⚠️ 1280.59MB 1280.57MB 140.00MB
datadog-agent-x86_64-suse 0.02MB ⚠️ 1280.59MB 1280.57MB 140.00MB
datadog-iot-agent-x86_64-rpm -0.01MB 113.28MB 113.29MB 10.00MB
datadog-iot-agent-x86_64-suse -0.01MB 113.28MB 113.29MB 10.00MB
datadog-dogstatsd-x86_64-rpm -0.00MB 78.41MB 78.41MB 10.00MB
datadog-dogstatsd-x86_64-suse -0.00MB 78.41MB 78.41MB 10.00MB
datadog-agent-arm64-deb 0.00MB 1005.48MB 1005.48MB 140.00MB
datadog-iot-agent-arm64-deb -0.01MB 108.70MB 108.71MB 10.00MB
datadog-dogstatsd-arm64-deb -0.01MB 55.59MB 55.60MB 10.00MB
datadog-agent-aarch64-rpm 0.00MB ⚠️ 1014.69MB 1014.69MB 140.00MB
datadog-iot-agent-aarch64-rpm -0.01MB 108.77MB 108.78MB 10.00MB

Decision

⚠️ Warning

@dd-mergequeue dd-mergequeue bot merged commit 886af76 into main Dec 11, 2024
365 checks passed
@dd-mergequeue dd-mergequeue bot deleted the pgimalac/remove-seelog-outside-pkg-util-log branch December 11, 2024 16:02
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.