[CWS] fix unmarshalling of regular int to time.Duration
#31769
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulcacheux
added
changelog/no-changelog
team/agent-security
qa/done
github-actions
bot
added
component/system-probe
short review
paulcacheux
changed the title
time.Durationtime.Duration
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=50362160 --os-family=ubuntuNote: This applies to commit c4f4c16 |
spikat
approved these changes
Dec 5, 2024
|
/merge |
Devflow running:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As opposed to json that unmarshals numbers to
float64, yaml will unmarshal them toint. This PR fixes this issue inHumanReadableDuration.Motivation
Describe how you validated your changes
Possible Drawbacks / Trade-offs
Additional Notes