AMLII-2207 - alter dogstatsd packet buffers to automatically flush when stream sockets disconnect

[ddrthall]

What does this PR do?

Force the dogstatsd packet buffer to flush while a stream socket is being closed

Motivation

Due to the requirements of the streaming UDS setup, socket connections are regularly created and closed. This is in contrast to the dgram UDS setup, which persists a single server-side socket throughout its entire life. The current packet buffer logic expects this latter setup, and isn't aggressive about persisting its data to the server workers on a socket closure. This causes a stream UDS client that connects, sends data, and disconnects to easily see that sent data lost.

Describe how you validated your changes

Utilize a dogstatsd client in a small program that generates a metric and then exits - on the current production code this metric is almost always lost, and on the modified code this metric is always persisted.

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50368716 --os-family=ubuntu

Note: This applies to commit 3d2093e

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 3c7bbd55-9448-4a8e-a07c-4d8f48b7a10f

Baseline: a29a766
Comparison: 3d2093e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_idle	memory utilization	+0.60	[+0.54, +0.66]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.55	[-0.19, +1.29]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.36	[-0.42, +1.14]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.19	[+0.05, +0.33]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.14	[-0.32, +0.59]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.03	[-0.75, +0.81]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.03	[-0.66, +0.72]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.09, +0.10]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.00	[-0.63, +0.62]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.01	[-0.90, +0.88]	1	Logs
➖	quality_gate_logs	% cpu utilization	-0.24	[-3.21, +2.73]	1	Logs
➖	otel_to_otel_logs	ingress throughput	-0.33	[-0.99, +0.33]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.36	[-0.42, -0.30]	1	Logs
➖	file_tree	memory utilization	-2.81	[-2.97, -2.66]	1	Logs

Bounds Checks: ✅ Passed

perf	experiment	bounds_check_name	replicates_passed	links
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

[ddrthall]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2024-12-05 18:14:40 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 23m.