[ebpfless] Implement connection duration and fix IsOpen #31763
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds bookkeeping for connection duration and IsOpen to the ebpfless TCP processor.
Motivation
Want the whole test suite to pass, goal is to have the test suite in a good state for KMT
Describe how you validated your changes
To run the test this fixes:
To run the TCP processor unit test suite:
To run just the unit test added by this PR:
Possible Drawbacks / Trade-offs
We have multiple sources of timestamps in the ebpfless tracer:
time.Now()
(used byDuration
)ddebpf.NowNanoseconds()
(used byconn.LastUpdateEpoch
and RTT)time.Time
parameter fromVisitPackets
(currently unused, but available)In a future PR, we might want to switch to a single source of truth for this.
Additional Notes