Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comp/otelcol/collector-contrib module path #31762

Merged

Conversation

pgimalac
Copy link
Member

@pgimalac pgimalac commented Dec 4, 2024

What does this PR do?

Fix the module path of comp/otelcol/collector-contrib to comp/otelcol/collector-contrib/impl.

Motivation

It causes issues when the replace directive is missing for that module, go complains that the path doesn't match.

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@pgimalac pgimalac added changelog/no-changelog team/opentelemetry OpenTelemetry team qa/no-code-change No code change in Agent code requiring validation labels Dec 4, 2024
@pgimalac pgimalac requested review from a team as code owners December 4, 2024 17:28
@pgimalac pgimalac requested a review from mx-psi December 4, 2024 17:28
@github-actions github-actions bot added the medium review PR review might take time label Dec 4, 2024
@pgimalac
Copy link
Member Author

pgimalac commented Dec 6, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 6, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-06 10:08:06 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 23m.

@dd-mergequeue dd-mergequeue bot merged commit d5c0d06 into main Dec 6, 2024
250 checks passed
@dd-mergequeue dd-mergequeue bot deleted the pgimalac/fix-module-path-comp-otelcol-collector-contrib branch December 6, 2024 10:34
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants