usm: sharedlibraries: Use fexit #31717
Draft
+92
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component/system-probe
short review
guyarb
force-pushed
the
guy.arbitman/sowatcher-fentry
branch
from
da4912c to
7e4c619
Compare
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=51530700 --os-family=ubuntuNote: This applies to commit 9270fd6 |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 52f0517 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | quality_gate_logs | % cpu utilization | +1.71 | [-1.19, +4.60] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.94 | [+0.80, +1.07] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.32 | [-0.15, +0.78] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.25 | [-0.47, +0.98] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.24 | [-0.48, +0.96] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http1 | egress throughput | +0.15 | [-0.77, +1.07] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.05 | [-0.73, +0.82] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency_http2 | egress throughput | +0.04 | [-0.86, +0.93] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.02 | [-0.62, +0.66] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.11, +0.12] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.04 | [-0.78, +0.71] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.06 | [-0.10, -0.02] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.07 | [-0.86, +0.73] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.23 | [-0.29, -0.17] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.32 | [-0.42, -0.21] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.56 | [-1.35, +0.22] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http1 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency_http2 | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
guyarb
force-pushed
the
guy.arbitman/sowatcher-fentry
branch
from
7e4c619 to
c323f19
Compare
guyarb
added
changelog/no-changelog
team/usm
guyarb
force-pushed
the
guy.arbitman/sowatcher-fentry
branch
3 times, most recently
from
301b837 to
66c06b9
Compare
guyarb
changed the base branch from
main
to
guy.arbitman/sowatcher-cut-inst-count
Package size comparisonComparison with ancestor Diff per package
Decision |
Base automatically changed from
guy.arbitman/sowatcher-cut-inst-count
to
main
December 10, 2024 09:09
guyarb
force-pushed
the
guy.arbitman/sowatcher-fentry
branch
3 times, most recently
from
4f01ed5 to
057f558
Compare
github-actions
bot
added
medium review
A preliminary change, to refactor 'do_sys_open_helper_enter' and 'do_sys_open_helper_exit` helper functions into a general purpose helpers 'fill_lib_path' and 'push_event_if_relevant'. The original helpers 'do_sys_open_helper_enter' and 'do_sys_open_helper_exit` now uses 'fill_lib_path' and 'push_event_if_relevant'. In the next commit we will use 'fiil_lib_path' and 'push_event_if_relevant' to implement fexit probe
Converting 2 tracpoints into a single fexit probe. Instead of having a tracpoint for 'sys_enter_openat2' and 'sys_exit_openat2', we can use fexit on openat2, to get both input arguments and return code in a single probe instead of caching the input arguments via a tracepoint on 'sys_enter_openat2' and pops them, and fetch the return code in the tracpoint on 'sys_exit_openat2'. The change will cut the perofrmance impact on 'open' syscall by ~50%, as we now use a single probe instead of 2 probes.
If the kernel supports openat2 syscall, it means that we're atleast on 5.6. Fexit is supported from 5.5. Thus, if the kernel supports openat2, then we use fexit on it, and ignore the tracpoints for openat and open. When openat2 syscall exists, the internal implementation of 'open' and 'openat' are folded into openat2, so we don't loose coverage by the change
guyarb
force-pushed
the
guy.arbitman/sowatcher-fentry
branch
from
434baff to
335799d
Compare
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
github-actions
bot
added
medium review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
Describe how you validated your changes
Possible Drawbacks / Trade-offs
Additional Notes