Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remade worktree unit tests #31653

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Conversation

CelianR
Copy link
Contributor

@CelianR CelianR commented Dec 2, 2024

What does this PR do?

Note

Please prefer reviewing this diff that doesn't include the un-comment part of the PR.

Worktree unit tests were disabled following this PR. Enabled again these tests by modifying them:

  • Mocked all git commands with a custom invoke context mock
    • The new worktree is a temporary directory that is removed before / after each test
    • Instead of git clone, the directory is created and modules.yml file is written (only this file is within this directory)
    • Instead of git checkout, the modules.yml file is changed
    • To test a context change, modules are loaded from modules.yml and compared
  • Fixed is_worktree() to resolve path
  • The get current branch test has been removed since it is not useful anymore (was testing only the mock)

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@CelianR CelianR added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-devx-infra labels Dec 2, 2024
@CelianR CelianR self-assigned this Dec 2, 2024
@github-actions github-actions bot added the medium review PR review might take time label Dec 2, 2024
@CelianR CelianR marked this pull request as ready for review December 2, 2024 13:14
@CelianR CelianR requested review from a team as code owners December 2, 2024 13:14
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 50206662 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 63fecab4-292f-4a55-81bf-38caccdcfa5e

Baseline: 1434b74
Comparison: f986fc9
Diff

Optimization Goals: ❌ Significant changes detected

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +6.88 [+2.80, +10.95] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +6.88 [+2.80, +10.95] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.55 [-0.19, +1.28] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.26 [-0.37, +0.90] 1 Logs
quality_gate_idle memory utilization +0.08 [+0.04, +0.13] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.01 [-0.46, +0.47] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.10, +0.09] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.03 [-0.83, +0.77] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.08 [-0.84, +0.69] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.11 [-0.82, +0.61] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.15 [-0.22, -0.08] 1 Logs
file_tree memory utilization -0.30 [-0.46, -0.15] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.45 [-1.24, +0.34] 1 Logs
quality_gate_idle_all_features memory utilization -0.49 [-0.62, -0.35] 1 Logs bounds checks dashboard
otel_to_otel_logs ingress throughput -0.59 [-1.29, +0.11] 1 Logs
pycheck_lots_of_tags % cpu utilization -1.02 [-4.44, +2.40] 1 Logs
quality_gate_logs % cpu utilization -3.80 [-6.70, -0.90] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@CelianR
Copy link
Contributor Author

CelianR commented Dec 3, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 3, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-03 12:17:42 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 24m.

@dd-mergequeue dd-mergequeue bot merged commit 01c8ef8 into main Dec 3, 2024
240 checks passed
@dd-mergequeue dd-mergequeue bot deleted the celian/worktree-unit-tests-reenable branch December 3, 2024 12:39
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-devx-infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants