[ASCII-2568] Remove Meter function from telemetry component #31596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team/agent-shared-components
long review
GustavoCaso
added
changelog/no-changelog
qa/no-code-change
Go Package Import DifferencesBaseline: 6570b54
|
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=50319791 --os-family=ubuntuNote: This applies to commit 9fe7f12 |
GustavoCaso
changed the title
pgimalac
approved these changes
Nov 29, 2024
comp/core/telemetry/go.mod
Outdated
| github.com/golang/protobuf v1.5.3 // indirect | ||
| github.com/google/go-cmp v0.6.0 // indirect |
There was a problem hiding this comment.
I have no idea to be honest. I just run inv -e tidy
mx-psi
approved these changes
Nov 29, 2024
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 6570b54 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | pycheck_lots_of_tags | % cpu utilization | +1.55 | [-2.00, +5.11] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +0.75 | [-2.24, +3.74] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.65 | [-0.08, +1.37] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.47 | [-0.16, +1.10] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.14 | [-0.32, +0.61] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.14 | [-0.63, +0.91] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.00 | [-0.68, +0.69] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.11, +0.11] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.08 | [-0.84, +0.68] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | -0.11 | [-0.74, +0.52] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.35 | [-1.13, +0.42] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.57 | [-0.72, -0.42] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.64 | [-0.69, -0.60] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -1.22 | [-1.28, -1.17] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -1.59 | [-1.68, -1.50] | 1 | Logs bounds checks dashboard |
| ➖ | basic_py_check | % cpu utilization | -3.28 | [-7.03, +0.48] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
hush-hush
approved these changes
Nov 29, 2024
vickenty
approved these changes
Nov 29, 2024
kkhor-datadog
approved these changes
Nov 29, 2024
truthbk
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
you might want to check with @gh123man on Monday (if he's available) if there's any issues with reworking the telemetry interface. Like you said, we don't seem to have any internal use for it, and for the most part, if this is compiling and CI is green I think we're good, but worth having that conversation (it's OK to discuss post-merge).
jszwedko
approved these changes
Dec 3, 2024
coignetp
approved these changes
Dec 4, 2024
ichinaski
approved these changes
Dec 4, 2024
|
/merge |
Devflow running:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes the
Meterfunction from the telemetry component.Back in 2022 when the RFC for components was created we said that we would use the Otel MeterProvider for instrument internal components. https://github.com/DataDog/architecture/blob/master/rfcs/agent-component-architecture/rfc.md#telemetry
As of today, we haven't found any internal usage.
Removing means we no longer add import many
go.opentelemetry.iolibraries into the different Agent binaries.If in the future we find internal usage, we can add it 😄
Motivation
removed unused function and libraries from the codebase.
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes