Replace --incremental-build by their --rebuild equivalent #31573

chouquette · 2024-11-28T15:47:15Z

What does this PR do?

Replace --incremental-build flags with --rebuild.

Change process_agent.build default to rebuild=False, all others are unchanged (rebuild=False).

Motivation

Simplify the build tasks

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr · 2024-11-28T15:50:09Z

Gitlab CI Configuration Changes

Modified Jobs

bootstrapper_build

  bootstrapper_build:
    artifacts:
      expire_in: 2 weeks
      paths:
      - $OMNIBUS_PACKAGE_DIR
    image: registry.ddbuild.io/ci/datadog-agent-buildimages/deb_x64$DATADOG_AGENT_BUILDIMAGES_SUFFIX:$DATADOG_AGENT_BUILDIMAGES
    needs:
    - go_mod_tidy_check
    - go_deps
    rules:
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - when: on_success
    script:
    - mkdir -p $GOPATH/pkg/mod/cache && tar xJf modcache.tar.xz -C $GOPATH/pkg/mod/cache
    - rm -f modcache.tar.xz
    - echo "About to build for $RELEASE_VERSION"
+   - GOOS=linux GOARCH=amd64 inv -e installer.build --bootstrapper --no-cgo --output-bin=$OMNIBUS_PACKAGE_DIR/bootstrapper-linux-amd64
+   - GOOS=linux GOARCH=arm64 inv -e installer.build --bootstrapper --no-cgo --output-bin=$OMNIBUS_PACKAGE_DIR/bootstrapper-linux-arm64
+   - GOOS=windows GOARCH=amd64 inv -e installer.build --bootstrapper --no-cgo --output-bin=$OMNIBUS_PACKAGE_DIR/bootstrapper-windows-amd64.exe
+   - GOOS=darwin GOARCH=amd64 inv -e installer.build --bootstrapper --no-cgo --output-bin=$OMNIBUS_PACKAGE_DIR/bootstrapper-darwin-amd64
+   - GOOS=darwin GOARCH=arm64 inv -e installer.build --bootstrapper --no-cgo --output-bin=$OMNIBUS_PACKAGE_DIR/bootstrapper-darwin-arm64
-   - GOOS=linux GOARCH=amd64 inv -e installer.build --bootstrapper --rebuild --no-cgo
-     --output-bin=$OMNIBUS_PACKAGE_DIR/bootstrapper-linux-amd64
-   - GOOS=linux GOARCH=arm64 inv -e installer.build --bootstrapper --rebuild --no-cgo
-     --output-bin=$OMNIBUS_PACKAGE_DIR/bootstrapper-linux-arm64
-   - GOOS=windows GOARCH=amd64 inv -e installer.build --bootstrapper --rebuild --no-cgo
-     --output-bin=$OMNIBUS_PACKAGE_DIR/bootstrapper-windows-amd64.exe
-   - GOOS=darwin GOARCH=amd64 inv -e installer.build --bootstrapper --rebuild --no-cgo
-     --output-bin=$OMNIBUS_PACKAGE_DIR/bootstrapper-darwin-amd64
-   - GOOS=darwin GOARCH=arm64 inv -e installer.build --bootstrapper --rebuild --no-cgo
-     --output-bin=$OMNIBUS_PACKAGE_DIR/bootstrapper-darwin-arm64
    - ls -la $OMNIBUS_PACKAGE_DIR
    stage: package_build
    tags:
    - arch:amd64
    variables:
      KUBERNETES_CPU_REQUEST: 8
      KUBERNETES_MEMORY_LIMIT: 16Gi
      KUBERNETES_MEMORY_REQUEST: 16Gi
      RELEASE_VERSION: $RELEASE_VERSION_7

Changes Summary

Removed	Modified	Added	Renamed
0	1	0	0

ℹ️ Diff available in the job log.

agent-platform-auto-pr · 2024-11-28T16:05:44Z

[Fast Unit Tests Report]

On pipeline 50379936 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

tests_deb-arm64-py3
tests_deb-x64-py3
tests_flavor_dogstatsd_deb-x64
tests_flavor_heroku_deb-x64
tests_flavor_iot_deb-x64
tests_rpm-arm64-py3
tests_rpm-x64-py3
tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

cit-pr-commenter · 2024-11-28T16:55:56Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 6ed0a502-52ec-458b-bb61-1ba0835d9dda

Baseline: 4538b2f
Comparison: eb056d5
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_idle_all_features	memory utilization	+1.27	[+1.14, +1.40]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.95	[+0.22, +1.67]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.35	[-0.43, +1.12]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.26	[+0.19, +0.33]	1	Logs
➖	quality_gate_logs	% cpu utilization	+0.19	[-2.71, +3.09]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.17	[-0.59, +0.94]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.08	[-0.56, +0.71]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.02	[-0.08, +0.13]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.00	[-0.84, +0.84]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.00	[-0.75, +0.74]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.01	[-0.47, +0.46]	1	Logs
➖	file_tree	memory utilization	-0.12	[-0.27, +0.03]	1	Logs
➖	quality_gate_idle	memory utilization	-0.21	[-0.26, -0.17]	1	Logs bounds checks dashboard
➖	otel_to_otel_logs	ingress throughput	-0.94	[-1.61, -0.26]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	file_to_blackhole_300ms_latency	lost_bytes	8/10
❌	file_to_blackhole_500ms_latency	lost_bytes	9/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

chouquette · 2024-11-29T14:15:51Z

/merge

dd-devflow · 2024-11-29T14:15:58Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-11-29 14:15:58 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 23m.

2024-11-29 14:16:24 UTC ❌ MergeQueue: This merge request has conflicts

This merge request conflicts with another merge request ahead in the queue.

The merge requests in front of this one are:

#31592 with merge sha d2acbb9
#31572 with merge sha 3ec4ae9
#31605 with merge sha a95dd2b

Please wait for the conflicting merge request(s) to merge. After they have merged, resolve any conflicts and add this merge request to the queue again.

Let the go build system do its job and rebuild what needs to be

BARX-712

chouquette · 2024-12-06T07:16:50Z

/merge

dd-devflow · 2024-12-06T07:16:57Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-12-06 07:16:56 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 23m.

chouquette added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-delivery labels Nov 28, 2024

chouquette requested review from a team as code owners November 28, 2024 15:47

chouquette force-pushed the chouquette/drop_incremental_rebuild_flag branch from 69432f0 to 3b3c397 Compare November 28, 2024 15:47

github-actions bot added the component/system-probe label Nov 28, 2024

paulcacheux approved these changes Nov 28, 2024

View reviewed changes

github-actions bot added the medium review PR review might take time label Nov 28, 2024

FlorentClarret approved these changes Nov 28, 2024

View reviewed changes

amenasria approved these changes Nov 29, 2024

View reviewed changes

coignetp approved these changes Nov 29, 2024

View reviewed changes

gjulianm approved these changes Nov 29, 2024

View reviewed changes

kkhor-datadog approved these changes Nov 29, 2024

View reviewed changes

chouquette force-pushed the chouquette/drop_incremental_rebuild_flag branch from 3b3c397 to 9aefd41 Compare November 29, 2024 15:18

chouquette added 5 commits December 5, 2024 09:56

omnibus: agent: don't pass --rebuild flag

e5ed8fa

Let the go build system do its job and rebuild what needs to be

omnibus: dogstatsd: don't provide --rebuild to the invoke task

59fdfe7

omnibus: iot-agent: don't provide --rebuild to invoke tasks

5ffb8c5

omnibus: installer: don't provide --rebuild to invoke tasks

3448bb8

tasks: replace --incremental-build parameters with --rebuild equivalent

87cf291

BARX-712

default to rebuild=False

eb056d5

chouquette force-pushed the chouquette/drop_incremental_rebuild_flag branch from d056e23 to eb056d5 Compare December 5, 2024 08:58

dd-mergequeue bot merged commit e46622a into main Dec 6, 2024
309 checks passed

dd-mergequeue bot deleted the chouquette/drop_incremental_rebuild_flag branch December 6, 2024 07:39

github-actions bot added this to the 7.62.0 milestone Dec 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace --incremental-build by their --rebuild equivalent #31573

Replace --incremental-build by their --rebuild equivalent #31573

chouquette commented Nov 28, 2024 •

edited by clarkb7

Loading

agent-platform-auto-pr bot commented Nov 28, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Nov 28, 2024 •

edited

Loading

cit-pr-commenter bot commented Nov 28, 2024 •

edited

Loading

Fine details of change detection per experiment

Explanation

chouquette commented Nov 29, 2024

dd-devflow bot commented Nov 29, 2024 •

edited

Loading

chouquette commented Dec 6, 2024

dd-devflow bot commented Dec 6, 2024 •

edited

Loading

Replace --incremental-build by their --rebuild equivalent #31573

Replace --incremental-build by their --rebuild equivalent #31573

Conversation

chouquette commented Nov 28, 2024 • edited by clarkb7 Loading

What does this PR do?

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr bot commented Nov 28, 2024 • edited Loading

Gitlab CI Configuration Changes

Modified Jobs

Changes Summary

agent-platform-auto-pr bot commented Nov 28, 2024 • edited Loading

cit-pr-commenter bot commented Nov 28, 2024 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ❌ Failed

Explanation

CI Pass/Fail Decision

chouquette commented Nov 29, 2024

dd-devflow bot commented Nov 29, 2024 • edited Loading

Devflow running: /merge

chouquette commented Dec 6, 2024

dd-devflow bot commented Dec 6, 2024 • edited Loading

Devflow running: /merge

chouquette commented Nov 28, 2024 •

edited by clarkb7

Loading

agent-platform-auto-pr bot commented Nov 28, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Nov 28, 2024 •

edited

Loading

cit-pr-commenter bot commented Nov 28, 2024 •

edited

Loading

dd-devflow bot commented Nov 29, 2024 •

edited

Loading

Devflow running: `/merge`

dd-devflow bot commented Dec 6, 2024 •

edited

Loading

Devflow running: `/merge`