Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USM: tests: add test helper to get empty config #31567

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

Yumasi
Copy link
Member

@Yumasi Yumasi commented Nov 28, 2024

What does this PR do?

This PR adds a test helper that creates a new network config, but with all of USM features disabled. This is meant to prevent unexpected test failures when enabling protocols by default as we have seen it happen with GoTLS and Istio mTLS.

Motivation

Prevent unexpected breakage.

Describe how to test/QA your changes

Change affects unit tests setup only + is covered by automated test to prevent future breakages due to USM config changes.

Possible Drawbacks / Trade-offs

Additional Notes

@Yumasi Yumasi added changelog/no-changelog component/system-probe team/usm The USM team qa/done QA done before merge and regressions are covered by tests labels Nov 28, 2024
@Yumasi Yumasi force-pushed the guillaume.pagnoux/USMON-1365-wrap-config-new branch from a550a35 to b6a1f01 Compare November 28, 2024 13:33
@github-actions github-actions bot added the medium review PR review might take time label Nov 28, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 28, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=50197572 --os-family=ubuntu

Note: This applies to commit e376478

@Yumasi Yumasi force-pushed the guillaume.pagnoux/USMON-1365-wrap-config-new branch from b6a1f01 to 98e2007 Compare November 28, 2024 14:10
@Yumasi Yumasi marked this pull request as ready for review November 28, 2024 14:10
@Yumasi Yumasi requested a review from a team as a code owner November 28, 2024 14:10
Copy link

cit-pr-commenter bot commented Nov 28, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: b3b8c987-c162-44f3-ad48-8ce128022aa3

Baseline: d06ed83
Comparison: e376478
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
tcp_syslog_to_blackhole ingress throughput +1.17 [+1.11, +1.24] 1 Logs
quality_gate_idle memory utilization +0.27 [+0.22, +0.32] 1 Logs bounds checks dashboard
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.07 [-0.39, +0.52] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.05 [-0.75, +0.86] 1 Logs
basic_py_check % cpu utilization +0.05 [-3.90, +4.00] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.05 [-0.71, +0.80] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.02 [-0.73, +0.78] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.12, +0.10] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.10 [-0.89, +0.69] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.10 [-0.73, +0.53] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.27 [-1.01, +0.47] 1 Logs
otel_to_otel_logs ingress throughput -0.37 [-1.05, +0.31] 1 Logs
file_tree memory utilization -0.40 [-0.55, -0.24] 1 Logs
pycheck_lots_of_tags % cpu utilization -1.18 [-4.67, +2.31] 1 Logs
quality_gate_idle_all_features memory utilization -1.67 [-1.79, -1.55] 1 Logs bounds checks dashboard
quality_gate_logs % cpu utilization -2.12 [-5.03, +0.79] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.

@Yumasi
Copy link
Member Author

Yumasi commented Dec 2, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Dec 2, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-12-02 11:23:16 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 23m.

@dd-mergequeue dd-mergequeue bot merged commit 0399385 into main Dec 2, 2024
295 checks passed
@dd-mergequeue dd-mergequeue bot deleted the guillaume.pagnoux/USMON-1365-wrap-config-new branch December 2, 2024 11:42
@github-actions github-actions bot added this to the 7.62.0 milestone Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/usm The USM team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants