Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the apm-ecosystems-reliability slack channel #31557

Conversation

FlorentClarret
Copy link
Member

What does this PR do?

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@FlorentClarret FlorentClarret requested review from a team as code owners November 28, 2024 10:47
@github-actions github-actions bot added team/agent-devx-loops short review PR is simple enough to be reviewed quickly team/agent-devx-infra labels Nov 28, 2024
@FlorentClarret FlorentClarret added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Nov 28, 2024
Copy link
Contributor

@CelianR CelianR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can replace this file by https://github.com/DataDog/web-ui/blob/776dc0246fb43e0fd2e7827bd12557d8f9ffd237/packages/lib/teams/teams-config.ts at some point. I'll maybe try to do that during the hackathon

@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 50100457 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

cit-pr-commenter bot commented Nov 28, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: d3a712c2-c326-4c5e-a420-51a8e1d83e39

Baseline: ae10a85
Comparison: ae10a85
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +1.57 [-2.40, +5.53] 1 Logs
quality_gate_idle memory utilization +0.74 [+0.67, +0.80] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.64 [+0.53, +0.74] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.06 [-0.73, +0.84] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.03 [-0.65, +0.72] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput +0.03 [-0.44, +0.50] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.10, +0.13] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.75, +0.76] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.63, +0.63] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
quality_gate_logs % cpu utilization -0.02 [-2.98, +2.95] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.08 [-0.86, +0.70] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.21 [-0.95, +0.52] 1 Logs
otel_to_otel_logs ingress throughput -0.23 [-0.89, +0.43] 1 Logs
file_tree memory utilization -0.37 [-0.51, -0.22] 1 Logs
quality_gate_idle_all_features memory utilization -0.55 [-0.68, -0.42] 1 Logs bounds checks dashboard
pycheck_lots_of_tags % cpu utilization -1.25 [-4.78, +2.28] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
quality_gate_logs memory_usage 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@FlorentClarret
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 29, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-29 09:59:17 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 24m.

@dd-mergequeue dd-mergequeue bot merged commit ae10a85 into main Nov 29, 2024
225 checks passed
@dd-mergequeue dd-mergequeue bot deleted the florentclarret/rename-apm-ecosystems-reliability-and-performance branch November 29, 2024 10:27
@github-actions github-actions bot added this to the 7.62.0 milestone Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-devx-infra team/agent-devx-loops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants