add collector update PR inv task and fix inv collector.update #31545

jackgopack4 · 2024-11-27T19:27:13Z

What does this PR do?

fixes memory leak in inv collector.update and moves logic for weekly collector update/generate task to separate bash script

Motivation

failed GH Actions run: https://github.com/DataDog/datadog-agent/actions/runs/12055965363

Describe how to test/QA your changes

run .github/scripts/otel-collector-update-generate.sh with $GITHUB_TOKEN in your environment

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr · 2024-11-27T19:57:16Z

[Fast Unit Tests Report]

On pipeline 50842050 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

tests_deb-arm64-py3
tests_deb-x64-py3
tests_flavor_dogstatsd_deb-x64
tests_flavor_heroku_deb-x64
tests_flavor_iot_deb-x64
tests_rpm-arm64-py3
tests_rpm-x64-py3
tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

cit-pr-commenter · 2024-11-27T20:28:14Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 9af330a2-6eb5-4403-ad1c-d97e0d9575ad

Baseline: 91dc636
Comparison: 48fa6b0
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_idle_all_features	memory utilization	+1.31	[+1.19, +1.44]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	+0.91	[+0.85, +0.97]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.67	[-0.13, +1.48]	1	Logs
➖	quality_gate_idle	memory utilization	+0.39	[+0.35, +0.44]	1	Logs bounds checks dashboard
➖	file_to_blackhole_500ms_latency	egress throughput	+0.11	[-0.66, +0.87]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.03	[-0.44, +0.49]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.02	[-0.83, +0.87]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.01	[-0.77, +0.79]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.00	[-0.81, +0.82]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.00	[-0.81, +0.81]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.02	[-0.12, +0.09]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.03	[-0.65, +0.60]	1	Logs
➖	otel_to_otel_logs	ingress throughput	-0.14	[-0.85, +0.56]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.23	[-0.96, +0.50]	1	Logs
➖	file_tree	memory utilization	-0.57	[-0.69, -0.46]	1	Logs
➖	quality_gate_logs	% cpu utilization	-1.29	[-4.23, +1.65]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	file_to_blackhole_500ms_latency	lost_bytes	9/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

.github/scripts/otel-collector-update-generate.sh

.github/workflows/collector-generate-and-update.yml

.github/scripts/otel-collector-update-generate.sh

pducolin · 2024-11-28T09:02:51Z

Ok for @DataDog/agent-devx-loops owned files

agent-platform-auto-pr · 2024-12-09T19:08:42Z

Package size comparison

Comparison with ancestor 91dc6364b51e2fda790ffe765975cf1fb1b9e3ac

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.00MB	✅	1271.32MB	1271.32MB	140.00MB
datadog-iot-agent-amd64-deb	0.00MB	✅	113.22MB	113.22MB	10.00MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	78.33MB	78.33MB	10.00MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	526.48MB	526.48MB	70.00MB
datadog-agent-x86_64-rpm	0.00MB	✅	1280.56MB	1280.56MB	140.00MB
datadog-agent-x86_64-suse	0.00MB	✅	1280.56MB	1280.56MB	140.00MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	113.29MB	113.29MB	10.00MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	113.29MB	113.29MB	10.00MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	78.41MB	78.41MB	10.00MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	78.41MB	78.41MB	10.00MB
datadog-agent-arm64-deb	0.00MB	✅	1005.47MB	1005.47MB	140.00MB
datadog-iot-agent-arm64-deb	0.00MB	✅	108.71MB	108.71MB	10.00MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	55.60MB	55.60MB	10.00MB
datadog-agent-aarch64-rpm	0.00MB	✅	1014.68MB	1014.68MB	140.00MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	108.78MB	108.78MB	10.00MB

Decision

✅ Passed

jackgopack4 · 2024-12-09T19:46:40Z

tasks/collector.py

@@ -479,8 +480,8 @@ def update_files(self):
            "./tasks/collector.py",
            "./.gitlab/integration_test/otel.yml",
        ]
-        for root, _, files in os.walk("./tasks/unit_tests/testdata/collector"):
-            for file in files:
+        for root, _, testfiles in os.walk("./tasks/unit_tests/testdata/collector"):


this was causing the memory leak when running locally

jackgopack4 · 2024-12-09T19:47:49Z

tasks/libs/ciproviders/github_api.py

@@ -64,11 +64,13 @@ def get_branch(self, branch_name):
                return None
            raise e

-    def create_pr(self, pr_title, pr_body, base_branch, target_branch):
+    def create_pr(self, pr_title, pr_body, base_branch, target_branch, draft=False):


was necessary to create a draft PR. I wanted to use a draft PR for this because collector dependency upgrade can break existing tests/codepaths and I want to be able to fix them before marking the PR ready.

chouetz

Thanks for the changes!

jackgopack4 · 2024-12-11T16:10:02Z

/merge

dd-devflow · 2024-12-11T16:10:27Z

Devflow running: `/merge`

View all feedbacks in Devflow UI.

2024-12-11 16:10:27 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 25m.

2024-12-11 16:58:12 UTC ℹ️ MergeQueue: This merge request was merged

jackgopack4 and others added 3 commits November 27, 2024 14:13

add collector update script and fix inv collector.update

6cbbd08

move logic to separate bash script for local running and testing

2bbc521

add setup go

678f78c

jackgopack4 requested review from a team and dineshg13 and removed request for a team November 27, 2024 19:27

github-actions bot added team/agent-devx-infra short review PR is simple enough to be reviewed quickly labels Nov 27, 2024

jackgopack4 added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Nov 27, 2024

jackgopack4 marked this pull request as ready for review November 27, 2024 19:34

jackgopack4 requested review from a team as code owners November 27, 2024 19:34

add opentelemetry as codeowners

2c78861

github-actions bot added medium review PR review might take time and removed short review PR is simple enough to be reviewed quickly labels Nov 27, 2024

chouetz requested changes Nov 28, 2024

View reviewed changes

pducolin approved these changes Nov 28, 2024

View reviewed changes

jackgopack4 and others added 6 commits December 9, 2024 09:41

Merge branch 'main' into jackgopack4/fix-collector-update-script

5334692

change approach to use inv task

0ce5815

Merge branch 'main' into jackgopack4/fix-collector-update-script

06452ed

add gofmt to collector generate

1dfe1d5

add no-verify to pr invoke

2ea4305

remove bad ref CODEOWNERS

77d43c4

jackgopack4 requested a review from chouetz December 9, 2024 19:42

fix typo

da34a8f

jackgopack4 changed the title ~~add collector update script and fix inv collector.update~~ add collector update PR inv task and fix inv collector.update Dec 9, 2024

dineshg13 approved these changes Dec 9, 2024

View reviewed changes

jackgopack4 commented Dec 9, 2024

View reviewed changes

github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Dec 9, 2024

jackgopack4 added 2 commits December 9, 2024 14:54

ad generate-licenses task to workflow

30d2bc9

add git config revert

7ea00d0

chouetz approved these changes Dec 11, 2024

View reviewed changes

Merge branch 'main' into jackgopack4/fix-collector-update-script

48fa6b0

dd-mergequeue bot merged commit 56af0ca into main Dec 11, 2024
211 checks passed

dd-mergequeue bot deleted the jackgopack4/fix-collector-update-script branch December 11, 2024 16:58

github-actions bot added this to the 7.62.0 milestone Dec 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add collector update PR inv task and fix inv collector.update #31545

add collector update PR inv task and fix inv collector.update #31545

jackgopack4 commented Nov 27, 2024

agent-platform-auto-pr bot commented Nov 27, 2024 •

edited

Loading

cit-pr-commenter bot commented Nov 27, 2024 •

edited

Loading

Fine details of change detection per experiment

Explanation

pducolin commented Nov 28, 2024

agent-platform-auto-pr bot commented Dec 9, 2024 •

edited

Loading

jackgopack4 Dec 9, 2024

jackgopack4 Dec 9, 2024

chouetz left a comment

jackgopack4 commented Dec 11, 2024

dd-devflow bot commented Dec 11, 2024 •

edited

Loading

add collector update PR inv task and fix inv collector.update #31545

add collector update PR inv task and fix inv collector.update #31545

Conversation

jackgopack4 commented Nov 27, 2024

What does this PR do?

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

agent-platform-auto-pr bot commented Nov 27, 2024 • edited Loading

cit-pr-commenter bot commented Nov 27, 2024 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ❌ Failed

Explanation

CI Pass/Fail Decision

pducolin commented Nov 28, 2024

agent-platform-auto-pr bot commented Dec 9, 2024 • edited Loading

Package size comparison

Decision

jackgopack4 Dec 9, 2024

Choose a reason for hiding this comment

jackgopack4 Dec 9, 2024

Choose a reason for hiding this comment

chouetz left a comment

Choose a reason for hiding this comment

jackgopack4 commented Dec 11, 2024

dd-devflow bot commented Dec 11, 2024 • edited Loading

Devflow running: /merge

agent-platform-auto-pr bot commented Nov 27, 2024 •

edited

Loading

cit-pr-commenter bot commented Nov 27, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 9, 2024 •

edited

Loading

dd-devflow bot commented Dec 11, 2024 •

edited

Loading

Devflow running: `/merge`