Delete test/kitchen folder #31525
Merged
Delete test/kitchen folder #31525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update gitlab-ci.yml Gitlab functional test cleanup removal
github-actions
bot
added
component/system-probe
team/agent-devx-loops
long review
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv aws.create-vm --pipeline-id=50418491 --os-family=ubuntuNote: This applies to commit 47c828f |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 48cbbbf Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +1.41 | [+0.69, +2.13] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.90 | [+0.25, +1.55] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.15 | [-0.49, +0.78] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.13 | [-0.67, +0.92] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.07 | [-0.64, +0.78] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.03 | [-0.81, +0.88] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.10, +0.07] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.04 | [-0.09, +0.00] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.09 | [-0.86, +0.67] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | -0.21 | [-0.68, +0.25] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.32 | [-0.44, -0.21] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.34 | [-0.41, -0.28] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.63 | [-0.77, -0.49] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -3.75 | [-6.64, -0.85] | 1 | Logs |
Bounds Checks: ❌ Failed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ❌ | file_to_blackhole_0ms_latency | lost_bytes | 9/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_logs | lost_bytes | 10/10 | |
| ✅ | quality_gate_logs | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
Gitlab CI Configuration Changes
|
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 33 | 13 | 0 | 2 |
ℹ️ Diff available in the job log.
…/kitchen-remove-everything
|
/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on |
Devflow running:
|
Devflow running:
|
|
/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on |
1 similar comment
|
/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on |
Devflow running:
|
Devflow running:
|
KevinFairise2
force-pushed
the
kfairise/kitchen-remove-everything
branch
from
0537b54 to
77f2225
Compare
|
/trigger-ci --variable RUN_ALL_BUILDS=true --variable RUN_KITCHEN_TESTS=true --variable RUN_E2E_TESTS=on --variable RUN_UNIT_TESTS=on --variable RUN_KMT_TESTS=on |
Devflow running:
|
FlorentClarret
approved these changes
Nov 29, 2024
tbavelier
approved these changes
Nov 29, 2024
hmahmood
approved these changes
Dec 2, 2024
AyyLam
approved these changes
Dec 2, 2024
alexn-dd
approved these changes
Dec 3, 2024
|
/merge |
Devflow running:
|
brycekahle
reviewed
Dec 3, 2024
tasks/system_probe.py
Outdated
Comment on lines
1013
to
1016
| # test/files/default/tests/pkg/network/testsuite | ||
| # test/files/default/tests/pkg/network/netlink/testsuite | ||
| # test/files/default/tests/pkg/ebpf/testsuite | ||
| # test/files/default/tests/pkg/ebpf/bytecode/testsuite |
There was a problem hiding this comment.
These comments are not accurate, because it will be rooted in ./test/new-e2e/tests/sysprobe-functional/artifacts
brycekahle
reviewed
Dec 3, 2024
tasks/kmt.py
Outdated
| @@ -1372,7 +1372,7 @@ def clean(ctx: Context, stack: str | None = None, container=False, image=False): | |||
| stack | |||
| ), f"Stack {stack} does not exist. Please create with 'inv kmt.create-stack --stack=<name>'" | |||
|
|
|||
| ctx.run("rm -rf ./test/kitchen/site-cookbooks/dd-system-probe-check/files/default/tests/pkg") | |||
| ctx.run("rm -rf ./test/files/default/tests/pkg") | |||
There was a problem hiding this comment.
This used to be {KITCHEN_ARTIFACT_DIR}/pkg, should it now be {E2E_ARTIFACT_DIR}/pkg?
brycekahle
reviewed
Dec 3, 2024
There was a problem hiding this comment.
This file may need to be modified and moved to the new location where these artifacts end up
brycekahle
reviewed
Dec 3, 2024
tasks/kernel_matrix_testing/ci.py
Outdated
| @@ -217,7 +217,7 @@ def get_test_results(self) -> dict[str, bool | None]: | |||
| The values are True if test passed, False if failed, None if skipped. | |||
| """ | |||
| junit_archive_name = f"junit-{self.arch}-{self.distro}-{self.vmset}.tar.gz" | |||
| junit_archive = self.artifact_file_binary(f"test/kitchen/{junit_archive_name}", ignore_not_found=True) | |||
| junit_archive = self.artifact_file_binary(f"test/{junit_archive_name}", ignore_not_found=True) | |||
There was a problem hiding this comment.
This was {DD_AGENT_TESTING_DIR}/{junit_archive_name} before, so I think it still needs to match that. I believe the default directory is now test/new-e2e/tests.
brycekahle
reviewed
Dec 3, 2024
tasks/kmt.py
Outdated
| @@ -2290,7 +2290,7 @@ def download_complexity_data(ctx: Context, commit: str, dest_path: str | Path, k | |||
| _, test_jobs = get_all_jobs_for_pipeline(pipeline_id) | |||
| for job in test_jobs: | |||
| complexity_name = f"verifier-complexity-{job.arch}-{job.distro}-{job.component}" | |||
| complexity_data_fname = f"test/kitchen/{complexity_name}.tar.gz" | |||
| complexity_data_fname = f"test/{complexity_name}.tar.gz" | |||
There was a problem hiding this comment.
This was {DD_AGENT_TESTING_DIR}/{complexity_name}.tar.gz before, so I think it still needs to match that. I believe the default directory is now test/new-e2e/tests.
brycekahle
reviewed
Dec 3, 2024
tasks/system_probe.py
Outdated
| @@ -1628,38 +1628,38 @@ def is_bpftool_compatible(ctx): | |||
| return False | |||
|
|
|||
|
|
|||
| def kitchen_prepare_btfs(ctx, files_dir, arch=CURRENT_ARCH): | |||
| def e2e_prepare_btfs(ctx, files_dir, arch=CURRENT_ARCH): | |||
There was a problem hiding this comment.
You can delete this entire function and the one reference. It is only needed when launching kitchen tests locally, which is not something that will be possible anymore.
brycekahle
requested changes
Dec 3, 2024
|
/merge -c |
Devflow running:
|
Indeed, I first wanted to move the artifacts at the root of |
brycekahle
approved these changes
Dec 4, 2024
brycekahle
approved these changes
Dec 4, 2024
|
/merge |
Devflow running:
|
|
/merge |
Devflow running:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Delete test/kitchen folder and update tests that were using this folder to store artifacts.
Motivation
Cleanup things that we no longer use
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes