Only set INSTALLATION environment variables when doing injection

[stanistan]

What does this PR do?

https://datadoghq.atlassian.net/browse/APMS-14061

We no longer set the environment variables when there is no library to inject (disabled namespace or otherwise).

Motivation

https://docs.google.com/document/d/1PHDp652AmVmNG--cJf0JpV_5OB6evtHZ_qxoZI2z0Pk/edit?tab=t.0

Describe how to test/QA your changes

Tests updated.

[agent-platform-auto-pr]

[Fast Unit Tests Report]

On pipeline 50576804 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: d8ba97f5-6518-4958-96c3-0bd3ae7532e1

Baseline: 4f9e172
Comparison: 993ee37
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+1.12	[-1.84, +4.08]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.76	[+0.63, +0.88]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	+0.53	[+0.07, +0.99]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.43	[-0.36, +1.22]	1	Logs
➖	file_tree	memory utilization	+0.36	[+0.24, +0.47]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.31	[-0.42, +1.04]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.17	[-0.47, +0.80]	1	Logs
➖	quality_gate_idle	memory utilization	+0.10	[+0.05, +0.14]	1	Logs bounds checks dashboard
➖	uds_dogstatsd_to_api	ingress throughput	+0.02	[-0.08, +0.11]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.00	[-0.85, +0.85]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.05	[-0.94, +0.83]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	-0.06	[-0.91, +0.78]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	-0.10	[-0.82, +0.62]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.10	[-0.17, -0.04]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	-0.16	[-0.93, +0.61]	1	Logs
➖	otel_to_otel_logs	ingress throughput	-0.52	[-1.20, +0.16]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	file_to_blackhole_0ms_latency_http1	lost_bytes	9/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[adel121]

question: why did you move this from a function call to an inline implementation?

[stanistan]

The inline implementation is in a podMutator with similar functionality (telemetry env var) which is basically exactly what this is. It didn't seem necessary to keep this around.

[stanistan]

I could have just called this function there I guess. 🤷

[stanistan]

@adel121 updated to use the function.

[adel121]

Thanks 👍

[adel121]

left small question

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50576804 --os-family=ubuntu

Note: This applies to commit 993ee37

[rtrieu]

Approving with minor feedback.

[stanistan]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2024-12-09 16:47:30 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 24m.