Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement AllKeyLowercase to be compatible with Viper #31480

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

hush-hush
Copy link
Member

What does this PR do?

Viper don't return known keys but only key with a value.

Describe how to test/QA your changes

All of this work is behind a feature flag and disable by default. Tests will be expended as the project get closer to a beta.

@hush-hush hush-hush requested a review from a team as a code owner November 26, 2024 11:15
@hush-hush hush-hush added changelog/no-changelog team/agent-shared-components qa/done QA done before merge and regressions are covered by tests labels Nov 26, 2024
@hush-hush hush-hush requested review from dustmop and removed request for jeremy-hanna November 26, 2024 11:15
Copy link

cit-pr-commenter bot commented Nov 26, 2024

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 953cd7c7-416f-44c1-9b2b-fd701b99e863

Baseline: 57b1ae5
Comparison: ed6634d
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle_all_features memory utilization +2.04 [+1.92, +2.15] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +1.40 [+1.34, +1.46] 1 Logs
basic_py_check % cpu utilization +1.19 [-2.71, +5.09] 1 Logs
quality_gate_logs % cpu utilization +1.14 [-1.79, +4.08] 1 Logs
file_tree memory utilization +1.11 [+0.95, +1.26] 1 Logs
quality_gate_idle memory utilization +0.74 [+0.70, +0.79] 1 Logs bounds checks dashboard
otel_to_otel_logs ingress throughput +0.45 [-0.28, +1.18] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.05 [-0.71, +0.80] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.05 [-0.59, +0.68] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.01 [-0.76, +0.77] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.10, +0.07] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.10 [-0.84, +0.64] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.14 [-0.59, +0.32] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.19 [-0.99, +0.60] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.03 [-1.76, -0.30] 1 Logs
pycheck_lots_of_tags % cpu utilization -4.74 [-8.10, -1.38] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_300ms_latency lost_bytes 9/10
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard
quality_gate_logs lost_bytes 10/10
quality_gate_logs memory_usage 10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Copy link
Contributor

@dustmop dustmop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some suggestions

pkg/config/nodetreemodel/config.go Show resolved Hide resolved
pkg/config/nodetreemodel/config.go Outdated Show resolved Hide resolved
pkg/config/nodetreemodel/config.go Outdated Show resolved Hide resolved
pkg/config/nodetreemodel/config.go Show resolved Hide resolved
pkg/config/nodetreemodel/config.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added the medium review PR review might take time label Nov 26, 2024
@hush-hush hush-hush force-pushed the maxime/implement-teeconfig branch 2 times, most recently from 265f7a0 to a0ca626 Compare November 28, 2024 14:59
@hush-hush hush-hush force-pushed the maxime/implement-allkeylowercase branch 2 times, most recently from 4d0f681 to fdbfe09 Compare November 28, 2024 15:25
@hush-hush hush-hush changed the title [WIP] Implement AllKeyLowercase to be compatible with Viper Implement AllKeyLowercase to be compatible with Viper Nov 28, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Nov 28, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=50120848 --os-family=ubuntu

Note: This applies to commit ed6634d

Base automatically changed from maxime/implement-teeconfig to main November 28, 2024 16:38
Viper don't return known keys but only key with a value
@hush-hush hush-hush force-pushed the maxime/implement-allkeylowercase branch from fdbfe09 to ed6634d Compare November 28, 2024 17:53
@hush-hush
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 28, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-28 17:53:49 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2024-11-28 18:41:38 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 24m.

@dd-mergequeue dd-mergequeue bot merged commit 9d960d3 into main Nov 28, 2024
214 checks passed
@dd-mergequeue dd-mergequeue bot deleted the maxime/implement-allkeylowercase branch November 28, 2024 19:07
@github-actions github-actions bot added this to the 7.61.0 milestone Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog medium review PR review might take time qa/done QA done before merge and regressions are covered by tests team/agent-shared-components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants