-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NPM] Add Enhanced TLS Tags #31464
Merged
Merged
[NPM] Add Enhanced TLS Tags #31464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component/system-probe
team/networks
long review
PR is complex, plan time to review it
labels
Nov 26, 2024
guyarb
reviewed
Dec 18, 2024
guyarb
reviewed
Dec 18, 2024
pkg/network/ebpf/c/protocols/classification/protocol-classification.h
Outdated
Show resolved
Hide resolved
guyarb
reviewed
Dec 18, 2024
guyarb
reviewed
Dec 18, 2024
guyarb
reviewed
Dec 18, 2024
guyarb
reviewed
Dec 18, 2024
guyarb
reviewed
Dec 18, 2024
guyarb
reviewed
Dec 18, 2024
guyarb
reviewed
Dec 18, 2024
guyarb
reviewed
Dec 18, 2024
pkg/network/ebpf/c/protocols/classification/protocol-classification.h
Outdated
Show resolved
Hide resolved
Uncompressed package size comparisonComparison with ancestor Diff per package
Decision |
guyarb
reviewed
Dec 23, 2024
guyarb
reviewed
Dec 23, 2024
guyarb
reviewed
Dec 23, 2024
guyarb
reviewed
Dec 23, 2024
guyarb
reviewed
Dec 23, 2024
guyarb
approved these changes
Dec 23, 2024
/merge |
Devflow running:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/system-probe
long review
PR is complex, plan time to review it
qa/done
QA done before merge and regressions are covered by tests
team/networks
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds eBPF side logic to parse the TLS hello packet payloads and extract the:
In order to do this the existing protocol classification tail call routing needed to be modified to:
A few other reviewer notes:
eBPF Complexity Changes
Details are below, but on average no program's complexity rose by more than 3.5%. In the worst case on amazonlinux 5.4 one program's complexity rose ~9%.
Motivation
https://datadoghq.atlassian.net/browse/NPM-3678
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes
Load Test Results
Available Here
Very small changes to CPU/memory within the margin of error of what we're accustomed to with the TCP load test. Most importantly, the new map
tls_enhanced_tags
stays small even after many hours.Staging dogfooding (oddish-c)
Test was run over a day, link here
NPM protocol tags for this cluster during the same period indicate no loss in resolution.