Refactor Go-DI template generation to use location expressions #31424

grantseltzer · 2024-11-25T14:54:07Z

What does this PR do?

This is a major refactor of the way Go-DI generates bpf programs. Instead
of generating bpf programs via templates for specific types, it breaks
down captures into basic building blocks of operations such as reading
from registers/stack, dereferencing, adding offsets, writing to output,
etc...

Templates are now these basic operations and as a result we can express
much more complex captures, such as pointers to pointers, slices of strings
or any combination of types that were previously supported.

Motivation

The previous iteration of Go-DI failed to be able to express complex types such as pointers to pointers. We didn't have a way of expressing any amount of multiple dereferences. This greatly increases the supported features/types for our customers to instrument.

Describe how to test/QA your changes

Run e2e tests

Possible Drawbacks / Trade-offs

Additional Notes

There is still one fix I need to push to this branch. It involves the way length is captured and encoded for embedded slices and strings.
I will be pushing more comments as well.
Have linting issues to fix

cit-pr-commenter · 2024-11-25T14:59:40Z

Go Package Import Differences

Baseline: e87eaec
Comparison: b345511

binary	os	arch	change
system-probe	linux	amd64	+1, -0 +golang.org/x/exp/rand
system-probe	linux	arm64	+1, -0 +golang.org/x/exp/rand

cit-pr-commenter · 2024-11-25T16:09:46Z

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: ac7999a0-6563-4b1b-8fe5-06a0a6b5be8c

Baseline: e49efd5
Comparison: 63fc80e
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	quality_gate_logs	% cpu utilization	+2.56	[-0.43, +5.55]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+1.18	[+1.05, +1.31]	1	Logs bounds checks dashboard
➖	otel_to_otel_logs	ingress throughput	+1.01	[+0.33, +1.69]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.43	[-0.29, +1.16]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.10	[-0.66, +0.87]	1	Logs
➖	file_to_blackhole_0ms_latency_http2	egress throughput	+0.09	[-0.71, +0.89]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.05	[-0.60, +0.70]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.05	[-0.58, +0.68]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.04	[-0.80, +0.87]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.02]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.11, +0.11]	1	Logs
➖	file_to_blackhole_0ms_latency_http1	egress throughput	-0.05	[-0.96, +0.86]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.16	[-0.94, +0.62]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.23	[-0.69, +0.22]	1	Logs
➖	quality_gate_idle	memory utilization	-0.24	[-0.28, -0.19]	1	Logs bounds checks dashboard
➖	tcp_syslog_to_blackhole	ingress throughput	-0.53	[-0.60, -0.46]	1	Logs
➖	file_tree	memory utilization	-0.55	[-0.67, -0.43]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	file_to_blackhole_100ms_latency	lost_bytes	5/10
❌	file_to_blackhole_0ms_latency	lost_bytes	9/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http1	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http1	memory_usage	10/10
✅	file_to_blackhole_0ms_latency_http2	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency_http2	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

✅ = significantly better comparison variant performance
❌ = significantly worse comparison variant performance
➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

pkg/dynamicinstrumentation/testutil/sample/kafka_go_forwarder/kafka_go_forwarder

agent-platform-auto-pr · 2024-12-11T21:31:42Z

Package size comparison

Comparison with ancestor e49efd5a1b34f2f86d5c5b7d46d41c95a9c90fe7

Diff per package

package	diff	status	size	ancestor	threshold
datadog-agent-amd64-deb	0.04MB	⚠️	1265.97MB	1265.93MB	140.00MB
datadog-iot-agent-amd64-deb	0.00MB	✅	113.29MB	113.29MB	10.00MB
datadog-dogstatsd-amd64-deb	0.00MB	✅	78.41MB	78.41MB	10.00MB
datadog-heroku-agent-amd64-deb	0.00MB	✅	526.65MB	526.65MB	70.00MB
datadog-agent-x86_64-rpm	0.04MB	⚠️	1275.20MB	1275.16MB	140.00MB
datadog-agent-x86_64-suse	0.04MB	⚠️	1275.20MB	1275.16MB	140.00MB
datadog-iot-agent-x86_64-rpm	0.00MB	✅	113.35MB	113.35MB	10.00MB
datadog-iot-agent-x86_64-suse	0.00MB	✅	113.35MB	113.35MB	10.00MB
datadog-dogstatsd-x86_64-rpm	0.00MB	✅	78.49MB	78.49MB	10.00MB
datadog-dogstatsd-x86_64-suse	0.00MB	✅	78.49MB	78.49MB	10.00MB
datadog-agent-arm64-deb	0.06MB	⚠️	1000.98MB	1000.93MB	140.00MB
datadog-iot-agent-arm64-deb	0.00MB	✅	108.76MB	108.76MB	10.00MB
datadog-dogstatsd-arm64-deb	0.00MB	✅	55.64MB	55.64MB	10.00MB
datadog-agent-aarch64-rpm	0.06MB	⚠️	1010.20MB	1010.14MB	140.00MB
datadog-iot-agent-aarch64-rpm	0.00MB	✅	108.83MB	108.83MB	10.00MB

Decision

⚠️ Warning

agent-platform-auto-pr · 2024-12-11T21:32:47Z

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=50960741 --os-family=ubuntu

Note: This applies to commit 26663d4

Signed-off-by: grantseltzer <[email protected]>

This is a major refactor of the way Go-DI generates bpf programs. Instead of generating bpf programs via templates for specific types, it breaks down captures into basic building blocks of operations such as reading from registers/stack, dereferencing, adding offsets, writing to output, etc... Templates are now these basic operations and as a result we can express much more complex captures, such as pointers to pointers, slices of strings or any combination of types that were previously supported. Signed-off-by: grantseltzer <[email protected]>

Signed-off-by: grantseltzer <[email protected]>

…instead of right before the values. Still need to update event parsing code Signed-off-by: grantseltzer <[email protected]>

Signed-off-by: grantseltzer <[email protected]>

This changes the logic for collection limit labels to create a new label before every slice element and jump to it accordingly. This is to avoid collissions such as in the case of embedded slices. Signed-off-by: grantseltzer <[email protected]>

Signed-off-by: grantseltzer <[email protected]>

cimi

Sending a first batch of comments, I still have a few files I didn't get to yet

pkg/dynamicinstrumentation/codegen/c/base_event.h

pkg/dynamicinstrumentation/codegen/c/dynamicinstrumentation.c

pkg/dynamicinstrumentation/codegen/c/event.h

pkg/dynamicinstrumentation/codegen/c/expressions.h

pkg/dynamicinstrumentation/codegen/c/macros.h

cimi · 2024-12-17T15:54:40Z

pkg/dynamicinstrumentation/codegen/codegen.go

I think this is an improvement over the previous code, it's more structured and I like the idea of the location opcodes driving code generation - however I find it hard to follow the logic here in these changes.

I'm treating the end to end tests as a confirmation that this works.

pkg/dynamicinstrumentation/codegen/expression_templates.go

pkg/dynamicinstrumentation/diconfig/config_manager.go

pkg/dynamicinstrumentation/diconfig/location_expression.go

brycekahle · 2024-12-17T19:50:57Z

pkg/dynamicinstrumentation/diconfig/location_expression.go

+
+	"github.com/DataDog/datadog-agent/pkg/dynamicinstrumentation/ditypes"
+	"github.com/DataDog/datadog-agent/pkg/util/log"
+	"golang.org/x/exp/rand"


I think you want math/rand or math/rand/v2 here

brycekahle · 2024-12-17T20:02:37Z

pkg/dynamicinstrumentation/diconfig/location_expression.go

+	length := 6
+	randomString := make([]byte, length)
+	for i := 0; i < length; i++ {
+		randomString[i] = byte(65 + rand.Intn(25))


What is 65 here? If you are just needing a random alphanumeric label, then this code works well:

func randomLabel() string { length := 6 buf := make([]byte, length/2) _, _ = rand.Read(buf) return hex.EncodeToString(buf) }

brycekahle · 2024-12-17T20:05:13Z

pkg/dynamicinstrumentation/diconfig/config_manager.go

@@ -127,7 +127,7 @@ func (cm *RCConfigManager) installConfigProbe(procInfo *ditypes.ProcessInfo) err
 	svcConfigProbe := *configProbe
 	svcConfigProbe.ServiceName = procInfo.ServiceName
 	procInfo.ProbesByID[configProbe.ID] = &svcConfigProbe
-
+	log.Infof("Installing config probe for service: %s.", svcConfigProbe.ServiceName)


nit: logs generally don't have punctuation at the end

go.mod

brycekahle · 2024-12-17T20:09:33Z

pkg/dynamicinstrumentation/testutil/sample/kafka_go_forwarder/main.go

+	"github.com/Shopify/sarama"
+	"github.com/confluentinc/confluent-kafka-go/v2/kafka"


These are net-new imports for the agent. Is there a way to write this test program using github.com/twmb/franz-go?

pkg/dynamicinstrumentation/codegen/c/expressions.h

Signed-off-by: grantseltzer <[email protected]>

…slice length limit Signed-off-by: grantseltzer <[email protected]>

Signed-off-by: grantseltzer <[email protected]>

brycekahle · 2024-12-17T22:28:10Z

pkg/dynamicinstrumentation/codegen/c/expressions.h

+        err = bpf_probe_read(&context.event->output[*(context.output_offset)+i], element_size, &valueHolder);
+        if (err != 0) {
+            log_debug("error when reading data while popping from bpf stack: %ld", err);
+            return_err = err;


Any reason you don't return early here?

brycekahle · 2024-12-17T22:57:30Z

pkg/dynamicinstrumentation/codegen/c/expressions.h

+    if (length > limit) {
+        length = limit;
+    }


duplicate of lines 294-296?

brycekahle · 2024-12-17T23:07:08Z

pkg/dynamicinstrumentation/codegen/c/maps.h

+    __uint(key_size, sizeof(__u32));
+    __uint(value_size, sizeof(char[PARAM_BUFFER_SIZE]));
+    __uint(max_entries, 1);
+} zeroval SEC(".maps");


FYI we have helper macros for defining maps in map-defs.h, so you can do things like BPF_ARRAY_MAP(zeroval, char[PARAM_BUFFER_SIZE], 1)

Signed-off-by: grantseltzer <[email protected]>

val06

first (partial) iteration.
covered mostly ebpf code and some small changes in go.

also as discussed in private few general comments on the bpf code:

replace bpf_probe_read with bpf_probe_read_user/bpf_probe_read_kernel
replace bpf_printk with log_debug
error flow -> in expressions.h, if you encounter an error do you want to continue the execution of the function? why not bail out immediately?

val06 · 2024-12-17T12:22:10Z

pkg/dynamicinstrumentation/codegen/c/base_event.h


 #include "ktypes.h"

-// NOTE: Be careful when adding fields, alignment should always be to 8 bytes
 struct base_event {


consider adding a comment to explain the "magic numbers" for this struct's fields of array type (304 and 10)
even better replace it with #define

val06 · 2024-12-17T12:31:38Z

pkg/dynamicinstrumentation/codegen/c/event.h

+struct event {
+    struct base_event base;
+    char output[PARAM_BUFFER_SIZE];
+};
+
+struct expression_context {
+    __u64 *output_offset;
+    struct pt_regs *ctx;
+    struct event *event;
+    __u64 *temp_storage;
+    char *zero_string;
+};


i assume those are the very core structs in your module, consider adding a short paragraph in code to explain their purpose (since the names of the structs are pretty generic)

val06 · 2024-12-17T12:32:53Z

pkg/dynamicinstrumentation/codegen/c/event.h

+
+struct event {
+    struct base_event base;
+    char output[PARAM_BUFFER_SIZE];


i think you need to include macros.h for the PARAM_BUFFER_SIZE

val06 · 2024-12-17T12:59:46Z

pkg/dynamicinstrumentation/codegen/c/expressions.h

+{
+    long err;
+    __u64 valueHolder = 0;
+    err = bpf_probe_read(&valueHolder,  element_size, &context.ctx->DWARF_REGISTER(reg));


it is better to use bpf_probe_read_kernel / bpf_probe_read_user instead of this helper.

consider using the wrappers (bpf_probe_read_kernel_with_telemetry / bpf_probe_read_user_with_telemetry) if you wish to get bpf errors telemetry (more details here)

this comment is relevant to all bpf code of DI

val06 · 2024-12-17T13:00:10Z

pkg/dynamicinstrumentation/codegen/c/expressions.h

+    __u64 valueHolder = 0;
+    err = bpf_probe_read(&valueHolder,  element_size, &context.ctx->DWARF_REGISTER(reg));
+    if (err != 0) {
+        bpf_printk("error when reading data from register: %d", err);


replace with log_debug as @gjulianm suggested

also, do you always try and push the parameter? if bpf_probe_read failed don't you want to bail out?

those 2 comments are relevant for all functions defined in this file

val06 · 2024-12-18T11:22:26Z

pkg/dynamicinstrumentation/ditypes/config.go

 	MaxReferenceDepth uint8 = 4     // MaxReferenceDepth is the default depth that DI will traverse datatypes for capturing values
 	MaxFieldCount           = 20    // MaxFieldCount is the default limit for how many fields DI will capture in a single data type
-	SliceMaxSize            = 1800  // SliceMaxSize is the default limit in bytes of a slice
-	SliceMaxLength          = 100   // SliceMaxLength is the default limit in number of elements of a slice
+	SliceMaxLength          = 3     // SliceMaxLength is the default limit in number of elements of a slice


was that change intentional? (seems like a large decrease)

val06 · 2024-12-18T11:22:44Z

pkg/dynamicinstrumentation/ditypes/arch_arm64.go

+
+package ditypes
+
+const StackRegister = 29


add a comment to explain this const, btw won't you have a name conflict with the same const in the amd64 file? (the build tags for those files are not mutually exclusive iiuc)

val06 · 2024-12-18T11:23:07Z

pkg/dynamicinstrumentation/ditypes/arch_amd64.go

+
+package ditypes
+
+const StackRegister = 7


add a comment to explain this const

val06 · 2024-12-18T11:24:37Z

pkg/dynamicinstrumentation/ditypes/analysis.go

+	Location            *Location
+	LocationExpressions []LocationExpression
+	FieldOffset         uint64
+	NotCaptureReason    NotCaptureReason


I would just call it Reason

val06 · 2024-12-18T11:25:20Z

pkg/dynamicinstrumentation/ditypes/analysis.go

@@ -34,14 +34,16 @@ type TypeMap struct {

 // Parameter represents a function parameter as read from DWARF info
 type Parameter struct {


document this struct's fields (inline one liners would be sufficient)

Signed-off-by: grantseltzer <[email protected]>

pkg/dynamicinstrumentation/codegen/c/maps.h

Signed-off-by: grantseltzer <[email protected]>

grantseltzer added team/dynamic-instrumentation Dynamic Instrumentation qa/no-code-change No code change in Agent code requiring validation labels Nov 25, 2024

grantseltzer requested review from a team as code owners November 25, 2024 14:54

github-actions bot added the component/system-probe label Nov 25, 2024

grantseltzer requested review from cimi and GreenMatan November 25, 2024 14:55

github-actions bot added the long review PR is complex, plan time to review it label Nov 25, 2024

grantseltzer removed the request for review from cimi November 25, 2024 14:56

grantseltzer force-pushed the grantseltzer/DEBUG-2982-multiple-dereference-support-2 branch 2 times, most recently from b3edbd7 to 924fb7f Compare December 2, 2024 18:52

cimi reviewed Dec 4, 2024

View reviewed changes

pkg/dynamicinstrumentation/testutil/sample/kafka_go_forwarder/kafka_go_forwarder Outdated Show resolved Hide resolved

grantseltzer force-pushed the grantseltzer/DEBUG-2982-multiple-dereference-support-2 branch 2 times, most recently from e1ffc3a to 3869f77 Compare December 11, 2024 17:12

grantseltzer added 12 commits December 13, 2024 15:07

Add more sample functions to sample service, add span creation

ed0860d

Signed-off-by: grantseltzer <[email protected]>

Break up bpf program into multiple headers

ac2a051

Signed-off-by: grantseltzer <[email protected]>

Rename header file with type that gets generated for Go consumption

25b7519

Signed-off-by: grantseltzer <[email protected]>

Fix dynamic string reading

67bead1

Signed-off-by: grantseltzer <[email protected]>

Change all Parameter uses to pointers

5438bcd

Signed-off-by: grantseltzer <[email protected]>

Fix strings and slice headers such that length is encoded in headers …

25b277f

…instead of right before the values. Still need to update event parsing code Signed-off-by: grantseltzer <[email protected]>

Update event parsing

6dc04b1

Signed-off-by: grantseltzer <[email protected]>

Fix strings, remove unneeded writing of length to output buffer

d3ba30e

Signed-off-by: grantseltzer <[email protected]>

Add location expressions for comments and print statements

88d3eac

Signed-off-by: grantseltzer <[email protected]>

Remove global map of seenTypes

cf11f6e

Signed-off-by: grantseltzer <[email protected]>

cimi reviewed Dec 17, 2024

View reviewed changes

brycekahle reviewed Dec 17, 2024

View reviewed changes

go.mod Show resolved Hide resolved

brycekahle reviewed Dec 17, 2024

View reviewed changes

pkg/dynamicinstrumentation/codegen/c/expressions.h Outdated Show resolved Hide resolved

brycekahle reviewed Dec 17, 2024

View reviewed changes

pkg/dynamicinstrumentation/codegen/c/expressions.h Outdated Show resolved Hide resolved

grantseltzer added 6 commits December 17, 2024 14:58

switch from bpf_printk to log_debug

f89e905

Signed-off-by: grantseltzer <[email protected]>

Fix the way limits are configured and applied, fix default value for …

5ec3963

…slice length limit Signed-off-by: grantseltzer <[email protected]>

rename variables in test

656a3e0

Signed-off-by: grantseltzer <[email protected]>

Fix location expression for capturing slice length

0cc21a0

Signed-off-by: grantseltzer <[email protected]>

Style fixes

350fbea

Signed-off-by: grantseltzer <[email protected]>

Remove span from sample service

0717905

Signed-off-by: grantseltzer <[email protected]>

brycekahle reviewed Dec 17, 2024

View reviewed changes

More comments/debugability

bc87164

Signed-off-by: grantseltzer <[email protected]>

grantseltzer force-pushed the grantseltzer/DEBUG-2982-multiple-dereference-support-2 branch from 63034f8 to bc87164 Compare December 18, 2024 01:46

val06 requested changes Dec 18, 2024

View reviewed changes

grantseltzer added 3 commits December 18, 2024 09:48

Make collection_limit a LRU

4374ca0

Signed-off-by: grantseltzer <[email protected]>

Add comments above all location expressions

52ae648

Signed-off-by: grantseltzer <[email protected]>

Add start of param parsing test

8b2e91b

Signed-off-by: grantseltzer <[email protected]>

brycekahle reviewed Dec 18, 2024

View reviewed changes

pkg/dynamicinstrumentation/codegen/c/maps.h Outdated Show resolved Hide resolved

grantseltzer and others added 6 commits December 18, 2024 13:10

Remove LRU

f9091f9

Signed-off-by: grantseltzer <[email protected]>

Add logic to clear the bpf stack map at the end of invocations

33d8015

Signed-off-by: grantseltzer <[email protected]>

Fix expression header file macro name

f07d69b

Signed-off-by: grantseltzer <[email protected]>

Remove apache license copyright from top of bpf files

d635dfb

Signed-off-by: grantseltzer <[email protected]>

Remove duplicate length check

0eb45ce

Signed-off-by: grantseltzer <[email protected]>

Remove kafka go forwarder sample for now

b345511

Signed-off-by: grantseltzer <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor Go-DI template generation to use location expressions #31424

Refactor Go-DI template generation to use location expressions #31424

grantseltzer commented Nov 25, 2024 •

edited

Loading

cit-pr-commenter bot commented Nov 25, 2024 •

edited

Loading

cit-pr-commenter bot commented Nov 25, 2024 •

edited

Loading

Fine details of change detection per experiment

Explanation

agent-platform-auto-pr bot commented Dec 11, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 11, 2024 •

edited

Loading

cimi left a comment

cimi Dec 17, 2024

brycekahle Dec 17, 2024

brycekahle Dec 17, 2024

brycekahle Dec 17, 2024

brycekahle Dec 17, 2024

brycekahle Dec 17, 2024

brycekahle Dec 17, 2024

brycekahle Dec 17, 2024

val06 left a comment •

edited

Loading

val06 Dec 17, 2024

val06 Dec 17, 2024

val06 Dec 17, 2024

val06 Dec 17, 2024

val06 Dec 17, 2024

val06 Dec 17, 2024

val06 Dec 17, 2024

val06 Dec 17, 2024

val06 Dec 18, 2024

val06 Dec 18, 2024

val06 Dec 18, 2024

val06 Dec 18, 2024

val06 Dec 18, 2024

		"github.com/Shopify/sarama"
		"github.com/confluentinc/confluent-kafka-go/v2/kafka"

		@@ -34,14 +34,16 @@ type TypeMap struct {

		// Parameter represents a function parameter as read from DWARF info
		type Parameter struct {

Refactor Go-DI template generation to use location expressions #31424

Are you sure you want to change the base?

Refactor Go-DI template generation to use location expressions #31424

Conversation

grantseltzer commented Nov 25, 2024 • edited Loading

What does this PR do?

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

cit-pr-commenter bot commented Nov 25, 2024 • edited Loading

Go Package Import Differences

cit-pr-commenter bot commented Nov 25, 2024 • edited Loading

Regression Detector

Regression Detector Results

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

Bounds Checks: ❌ Failed

Explanation

CI Pass/Fail Decision

agent-platform-auto-pr bot commented Dec 11, 2024 • edited Loading

Package size comparison

Decision

agent-platform-auto-pr bot commented Dec 11, 2024 • edited Loading

Test changes on VM

cimi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

val06 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

grantseltzer commented Nov 25, 2024 •

edited

Loading

cit-pr-commenter bot commented Nov 25, 2024 •

edited

Loading

cit-pr-commenter bot commented Nov 25, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 11, 2024 •

edited

Loading

agent-platform-auto-pr bot commented Dec 11, 2024 •

edited

Loading

val06 left a comment •

edited

Loading