Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EBPF] gpu: mark TestVectorAddProgramDetected as flaky #31387

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

gjulianm
Copy link
Contributor

@gjulianm gjulianm commented Nov 22, 2024

What does this PR do?

This PR marks the TestVectorAddProgramDetected as flaky

Motivation

Avoid main failures. For some reason sometimes the vectorAdd program is not finding the GPU.

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@gjulianm gjulianm self-assigned this Nov 22, 2024
@github-actions github-actions bot added team/ebpf-platform short review PR is simple enough to be reviewed quickly labels Nov 22, 2024
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 49742607 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=49742607 --os-family=ubuntu

Note: This applies to commit ca3cf73

@gjulianm gjulianm added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Nov 22, 2024
@gjulianm gjulianm marked this pull request as ready for review November 22, 2024 16:36
@gjulianm gjulianm requested a review from a team as a code owner November 22, 2024 16:36
Copy link

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: b52af418-7009-4cac-8f2e-33e6ed56ef4b

Baseline: 41dbc07
Comparison: ca3cf73
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_idle_all_features memory utilization +4.01 [+3.86, +4.17] 1 Logs bounds checks dashboard
quality_gate_idle memory utilization +0.36 [+0.29, +0.43] 1 Logs bounds checks dashboard
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.78, +0.77] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.11, +0.08] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.01 [-0.63, +0.60] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.02 [-0.80, +0.76] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.03 [-0.78, +0.71] 1 Logs
file_to_blackhole_1000ms_latency_linear_load egress throughput -0.29 [-0.75, +0.18] 1 Logs
pycheck_lots_of_tags % cpu utilization -0.42 [-3.99, +3.14] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.52 [-1.30, +0.27] 1 Logs
otel_to_otel_logs ingress throughput -0.74 [-1.37, -0.10] 1 Logs
file_tree memory utilization -0.75 [-0.88, -0.62] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.85 [-0.93, -0.78] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.17 [-1.90, -0.45] 1 Logs
basic_py_check % cpu utilization -4.87 [-8.73, -1.01] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed links
file_to_blackhole_0ms_latency lost_bytes 10/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency_linear_load memory_usage 10/10
file_to_blackhole_100ms_latency lost_bytes 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency lost_bytes 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency lost_bytes 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
quality_gate_idle memory_usage 10/10 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

@gjulianm
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Nov 25, 2024

Devflow running: /merge

View all feedbacks in Devflow UI.


2024-11-25 11:10:13 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 24m.

@dd-mergequeue dd-mergequeue bot merged commit bd259ed into main Nov 25, 2024
224 of 225 checks passed
@dd-mergequeue dd-mergequeue bot deleted the guillermo.julian/vectoradd-flaky branch November 25, 2024 11:29
@github-actions github-actions bot added this to the 7.61.0 milestone Nov 25, 2024
@gjulianm gjulianm added the backport/7.60.x Automatically create a backport PR to 7.60.x label Dec 5, 2024
@agent-platform-auto-pr
Copy link
Contributor

The backport to 7.60.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.60.x 7.60.x
# Navigate to the new working tree
cd .worktrees/backport-7.60.x
# Create a new branch
git switch --create backport-31387-to-7.60.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bd259ed3d3ce2e18631bdb38ecfd9872a1108ba3
# Push it to GitHub
git push --set-upstream origin backport-31387-to-7.60.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.60.x

Then, create a pull request where the base branch is 7.60.x and the compare/head branch is backport-31387-to-7.60.x.

gjulianm added a commit that referenced this pull request Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/7.60.x Automatically create a backport PR to 7.60.x changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/ebpf-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants