Bump windows docker memory for linter

[KevinFairise2]

What does this PR do?

We recently bumped size of Windows runner after seeing flakiness coming from lack of memory on linter job. We should now bump the parameters on docker run to specify how much memory the linter can use

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

Gitlab CI Configuration Changes

Modified Jobs

.lint_windows_base

  .lint_windows_base:
    needs:
    - go_deps
    - go_tools_deps
    script:
    - $ErrorActionPreference = "Stop"
    - $_instance_id = (iwr  -UseBasicParsing http://169.254.169.254/latest/meta-data/instance-id).content
      ; Write-Host "Running on instance $($_instance_id)"
-   - 'docker run --rm -m 16384M --storage-opt "size=50GB" -v "$(Get-Location):c:\mnt"
?                         ^ ---
+   - 'docker run --rm -m 24576M --storage-opt "size=50GB" -v "$(Get-Location):c:\mnt"
?                         ^^^^
      -e AWS_NETWORKING=true -e CI_PIPELINE_ID=${CI_PIPELINE_ID} -e CI_PROJECT_NAME=${CI_PROJECT_NAME}
      -e GOMODCACHE="c:\modcache" registry.ddbuild.io/ci/datadog-agent-buildimages/windows_1809_${ARCH}${Env:DATADOG_AGENT_WINBUILDIMAGES_SUFFIX}:$Env:DATADOG_AGENT_WINBUILDIMAGES
      c:\mnt\tasks\winbuildscripts\lint.bat
  
      '
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    stage: lint
    tags:
    - runner:windows-docker
    - windowsversion:1809

lint_windows-x64

  lint_windows-x64:
    needs:
    - go_deps
    - go_tools_deps
    rules:
    - if: $CI_COMMIT_BRANCH =~ /^mq-working-branch-/
      when: never
    - when: on_success
    script:
    - $ErrorActionPreference = "Stop"
    - $_instance_id = (iwr  -UseBasicParsing http://169.254.169.254/latest/meta-data/instance-id).content
      ; Write-Host "Running on instance $($_instance_id)"
-   - 'docker run --rm -m 16384M --storage-opt "size=50GB" -v "$(Get-Location):c:\mnt"
?                         ^ ---
+   - 'docker run --rm -m 24576M --storage-opt "size=50GB" -v "$(Get-Location):c:\mnt"
?                         ^^^^
      -e AWS_NETWORKING=true -e CI_PIPELINE_ID=${CI_PIPELINE_ID} -e CI_PROJECT_NAME=${CI_PROJECT_NAME}
      -e GOMODCACHE="c:\modcache" registry.ddbuild.io/ci/datadog-agent-buildimages/windows_1809_${ARCH}${Env:DATADOG_AGENT_WINBUILDIMAGES_SUFFIX}:$Env:DATADOG_AGENT_WINBUILDIMAGES
      c:\mnt\tasks\winbuildscripts\lint.bat
  
      '
    - If ($lastExitCode -ne "0") { throw "Previous command returned $lastExitCode" }
    stage: lint
    tags:
    - runner:windows-docker
    - windowsversion:1809
    timeout: 1h30m
    variables:
      ARCH: x64

Changes Summary

Removed	Modified	Added	Renamed
0	2	0	0

ℹ️ Diff available in the job log.

[agent-platform-auto-pr]

[Fast Unit Tests Report]

On pipeline 49701313 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_deb-arm64-py3
• tests_deb-x64-py3
• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64
• tests_rpm-arm64-py3
• tests_rpm-x64-py3
• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: f6c6b47f-b352-4b6b-9ad8-2d3ffb62b2d6

Baseline: 45b5880
Comparison: 36ac379
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	pycheck_lots_of_tags	% cpu utilization	+4.45	[+0.84, +8.06]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.42	[+0.35, +0.50]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+0.22	[+0.11, +0.32]	1	Logs bounds checks dashboard
➖	file_to_blackhole_300ms_latency	egress throughput	+0.18	[-0.45, +0.81]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.13	[-0.74, +1.00]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.11	[-0.66, +0.89]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.09, +0.11]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	file_tree	memory utilization	-0.02	[-0.15, +0.12]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	-0.03	[-0.83, +0.78]	1	Logs
➖	quality_gate_idle	memory utilization	-0.05	[-0.10, -0.00]	1	Logs bounds checks dashboard
➖	file_to_blackhole_100ms_latency	egress throughput	-0.07	[-0.79, +0.66]	1	Logs
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.25	[-0.72, +0.21]	1	Logs
➖	basic_py_check	% cpu utilization	-0.61	[-4.38, +3.17]	1	Logs
➖	otel_to_otel_logs	ingress throughput	-1.02	[-1.69, -0.34]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-1.50	[-2.21, -0.79]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	file_to_blackhole_0ms_latency	lost_bytes	7/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	lost_bytes	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[KevinFairise2]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2024-11-22 10:03:45 UTC ℹ️ MergeQueue: pull request added to the queue

The median merge time in main is 23m.

[agent-platform-auto-pr]

The backport to 6.53.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-6.53.x 6.53.x
# Navigate to the new working tree
cd .worktrees/backport-6.53.x
# Create a new branch
git switch --create backport-31369-to-6.53.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 88a886d29e5d6c1791a16b919fb4434638971fc0
# Push it to GitHub
git push --set-upstream origin backport-31369-to-6.53.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-6.53.x

Then, create a pull request where the base branch is 6.53.x and the compare/head branch is backport-31369-to-6.53.x.