-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid looking up core agent hostname in tests that don't need it #31357
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=49744161 --os-family=ubuntu Note: This applies to commit 3d008ae |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: bd961d3 Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +2.23 | [+1.49, +2.97] | 1 | Logs |
➖ | file_tree | memory utilization | +0.84 | [+0.69, +0.98] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.79 | [+0.72, +0.85] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.58 | [+0.11, +1.04] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | +0.13 | [+0.06, +0.20] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_0ms_latency | egress throughput | +0.06 | [-0.71, +0.82] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | +0.01 | [-0.72, +0.75] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | +0.01 | [-0.62, +0.63] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.10, +0.10] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | -0.08 | [-0.85, +0.70] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.20 | [-0.97, +0.57] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.72 | [-1.40, -0.04] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -1.17 | [-1.32, -1.02] | 1 | Logs bounds checks dashboard |
➖ | basic_py_check | % cpu utilization | -2.21 | [-6.11, +1.70] | 1 | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | -4.11 | [-7.59, -0.62] | 1 | Logs |
Bounds Checks: ✅ Passed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
/merge |
Devflow running:
|
What does this PR do?
Manually configure a hostname in tests that aren't testing the logic of hostname detection.
Motivation
My primary motivation here was to reduce flakes as this hostname detection can flake on creating the grpc connection to the core agent. I haven't yet determined why that can happen but in the interest of unskipping these couple tests and stopping additional flakes I've made this PR to avoid that flaky logic.
Secondarily there's a really nice time benefit here as every single test here that was trying to form a connection would block and wait for 2 seconds before erroring on the timeout. Now that the logic is skipped the tests in this package go from taking ~100 seconds to ~21 seconds on my local machine. This might result in some CI savings which is always nice :)
Describe how to test/QA your changes
N/A
Possible Drawbacks / Trade-offs
I still haven't determined exactly why this specific logic can flake so it's non ideal that it's still used for some tests, but seeing that this should be a strict improvement over the current state I think this is worth the change.
Additional Notes