Remove serverless dependencies test. #31149
Conversation
purple4reina
added
changelog/no-changelog
team/serverless
qa/done
Gitlab CI Configuration ChangesRemoved Jobs
Changes Summary
ℹ️ Diff available in the job log. |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=49189471 --os-family=ubuntuNote: This applies to commit d6e47ae |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 88703d8 Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | pycheck_lots_of_tags | % cpu utilization | +2.45 | [-1.10, +6.01] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +1.79 | [+1.62, +1.95] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.72 | [+0.66, +0.79] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.20 | [-0.44, +0.84] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency_linear_load | egress throughput | +0.17 | [-0.29, +0.62] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.08, +0.10] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.02, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.00 | [-0.85, +0.84] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.01 | [-0.77, +0.75] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | -0.01 | [-0.64, +0.62] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.02 | [-0.79, +0.76] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.13 | [-0.90, +0.63] | 1 | Logs |
| ➖ | basic_py_check | % cpu utilization | -0.54 | [-4.36, +3.28] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.59 | [-1.31, +0.14] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.62 | [-0.72, -0.52] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.74 | [-0.80, -0.67] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | links |
|---|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_1000ms_latency_linear_load | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | lost_bytes | 10/10 | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | |
| ✅ | quality_gate_idle | memory_usage | 10/10 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
tasks/go_deps.py
Outdated
| 'arch': f'The architecture to use, one of {", ".join(GOARCH_MAPPING.keys())}. Defaults to host architecture', | ||
| } | ||
| ) | ||
| def show(ctx: Context, build: str, flavor: str = AgentFlavor.base.name, os: str | None = None, arch: str | None = None): |
There was a problem hiding this comment.
Can you leave this invoke task please ? I think it's still useful
There was a problem hiding this comment.
Agree with that. I would just remove the CI check and leave all the invoke task as they might be useful for other uscases in the future 😄
| // This product includes software developed at Datadog (https://www.datadoghq.com/). | ||
| // Copyright 2016-present Datadog, Inc. | ||
|
|
||
| package binarysize |
There was a problem hiding this comment.
Should we remove this one as well?
There was a problem hiding this comment.
I feel like this one is still mildly helpful. While it's okay that the binary size increases now, it's still not ideal. It seems like we've determined that github.com/h2non/filetype is one culprit.
Happy to hear your thoughts otherwise though! I'm all about deleting code. 😅
There was a problem hiding this comment.
Actually, I take this back. I will delete this test. This PR is adding this, it wasn't there previously. We don't need it, so why add it?
purple4reina
force-pushed
the
rey.abolofia/rm-dep-test
branch
from
b998cb0 to
8c39607
Compare
This reverts commit 7ac9c8b.
purple4reina
force-pushed
the
rey.abolofia/rm-dep-test
branch
from
8c39607 to
a239545
Compare
|
/merge |
Devflow running:
|
|
📥 📢 Info, this pull request increases the binary size of serverless extension by 0 bytes. Each MB of binary size increase means about 10ms of additional cold start time, so this pull request would increase cold start time by 0ms. Debug infoIf you have questions, we are happy to help, come visit us in the #serverless slack channel and provide a link to this comment. We suggest you consider adding the |
Serverless Benchmark Results
tl;drUse these benchmarks as an insight tool during development.
What is this benchmarking?The The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type. How do I interpret these charts?The charts below comes from The benchstat docs explain how to interpret these charts.
I need more helpFirst off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development. If you would like a hand interpreting the results come chat with us in Benchmark stats |
What does this PR do?
Reverts #25866 and #24770.
Motivation
Now that we are moving to bottlecap by default, we no longer care about the cold start time here in the extension code.
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes