[CSM] Prevent CSM program ID leak in ebpfcheck

[Gui774ume]

What does this PR do?

This PR ensures updates to mapModuleMapping and progNameMapping are done where programs are truly added and removed from our manager. CSM loads and unloads programs dynamically based on ruleset updates or container scheduling. Without this change, the two maps may end up out of sync, and leak map entries.

Motivation

Prevent a leak of entries in mapModuleMapping and progNameMapping.

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=50100027 --os-family=ubuntu

Note: This applies to commit 386a369

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 465379a1-e8c1-4b96-a796-5dd1b21311b0

Baseline: 90bfbe5
Comparison: 386a369
Diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	pycheck_lots_of_tags	% cpu utilization	+4.55	[+0.90, +8.19]	1	Logs
➖	basic_py_check	% cpu utilization	+3.54	[-0.41, +7.49]	1	Logs
➖	quality_gate_idle_all_features	memory utilization	+1.62	[+1.51, +1.72]	1	Logs bounds checks dashboard
➖	quality_gate_logs	% cpu utilization	+1.42	[-1.54, +4.39]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.93	[+0.20, +1.66]	1	Logs
➖	file_tree	memory utilization	+0.63	[+0.48, +0.78]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.18	[-0.50, +0.85]	1	Logs
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.07	[-0.70, +0.84]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	+0.06	[-0.58, +0.69]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.01	[-0.76, +0.79]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.01	[-0.74, +0.76]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.04	[-0.14, +0.07]	1	Logs
➖	quality_gate_idle	memory utilization	-0.07	[-0.12, -0.02]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency_linear_load	egress throughput	-0.16	[-0.61, +0.30]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.79	[-0.85, -0.72]	1	Logs
➖	otel_to_otel_logs	ingress throughput	-0.94	[-1.65, -0.22]	1	Logs

Bounds Checks: ❌ Failed

perf	experiment	bounds_check_name	replicates_passed	links
❌	file_to_blackhole_100ms_latency	lost_bytes	9/10
✅	file_to_blackhole_0ms_latency	lost_bytes	10/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency_linear_load	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	lost_bytes	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	lost_bytes	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	quality_gate_idle	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_idle_all_features	memory_usage	10/10	bounds checks dashboard
✅	quality_gate_logs	lost_bytes	10/10
✅	quality_gate_logs	memory_usage	10/10

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

✅ Passed. All Quality Gates passed.

• quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_logs, bounds check lost_bytes: 10/10 replicas passed. Gate passed.
• quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
• quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

[brycekahle]

Won't this fail if the program has been unloaded?

[Gui774ume]

Yup you're right, thanks ! Should be fixed now 👍🏻

[Gui774ume]

/merge

[dd-devflow]

Devflow running: /merge

View all feedbacks in Devflow UI.

---

2024-11-28 09:38:04 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

---

2024-11-28 11:43:23 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 22m.