-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[usm] service discovery, add ignored services 'security-agent' and 'system-probe' to system-probe config #30927
[usm] service discovery, add ignored services 'security-agent' and 'system-probe' to system-probe config #30927
Conversation
…ystem-probe' to system-probe config
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=48617375 --os-family=ubuntu Note: This applies to commit 608cb02 |
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 92bf87a Optimization Goals: ✅ No significant changes detected
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | pycheck_lots_of_tags | % cpu utilization | +4.76 | [+1.30, +8.22] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.41 | [-0.31, +1.14] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | +0.27 | [-0.40, +0.95] | 1 | Logs |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.11 | [-0.13, +0.36] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | +0.03 | [-0.16, +0.23] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | -0.02 | [-0.34, +0.31] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | -0.02 | [-0.50, +0.46] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.03 | [-0.13, +0.08] | 1 | Logs |
➖ | quality_gate_idle_all_features | memory utilization | -0.05 | [-0.15, +0.06] | 1 | Logs bounds checks dashboard |
➖ | file_tree | memory utilization | -0.10 | [-0.23, +0.03] | 1 | Logs |
➖ | quality_gate_idle | memory utilization | -0.25 | [-0.30, -0.20] | 1 | Logs bounds checks dashboard |
➖ | basic_py_check | % cpu utilization | -0.31 | [-4.05, +3.42] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.43 | [-0.49, -0.37] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.51 | [-1.00, -0.03] | 1 | Logs |
Bounds Checks: ❌ Failed
perf | experiment | bounds_check_name | replicates_passed | links |
---|---|---|---|---|
❌ | file_to_blackhole_100ms_latency | lost_bytes | 5/10 | |
❌ | quality_gate_idle | memory_usage | 6/10 | bounds checks dashboard |
❌ | quality_gate_idle_all_features | memory_usage | 9/10 | bounds checks dashboard |
✅ | file_to_blackhole_0ms_latency | lost_bytes | 10/10 | |
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 | |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge |
Devflow running:
|
What does this PR do?
Adds two Datadog services "system-probe", "security-agent" to list of ignored services in system-probe config file.
Motivation
Datadog services should not be reported as discovered services on the system.
Describe how to test/QA your changes
Passed service discovery unit tests on local VM
PASS
ok github.com/DataDog/datadog-agent/pkg/collector/corechecks/servicediscovery/module 39.196s
Possible Drawbacks / Trade-offs
Additional Notes