Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NPM-3663] Include BTF availability in agent flare #30440

Merged
merged 19 commits into from
Oct 31, 2024

Conversation

pimlu
Copy link
Contributor

@pimlu pimlu commented Oct 23, 2024

What does this PR do?

This PR adds information about where we are loading BTF information from to the agent flare.

Motivation

This can tell us why CO-RE is running into issues, and particularly with our bundled BTF files, if we are correctly identifying the distro + kernel.

Describe how to test/QA your changes

Install the agent from the CI build packages, configure the system-probe to run and run an agent flare. Expect to see system-probe/ebpf_btf_loader.log with this information. Example when cilium loads the BTF data:

loader: kernel
source file: <unknown, internal to cilium ebpf>

If the data comes from a user configured BTF file or our bundled BTF files, the source file: field will contain the path to that BTF file.

Possible Drawbacks / Trade-offs

Additional Notes

Copy link

cit-pr-commenter bot commented Oct 23, 2024

Regression Detector

Regression Detector Results

Run ID: 0e175603-bcfa-4103-a8fc-6504b6886feb Metrics dashboard Target profiles

Baseline: 2f80c77
Comparison: cf5c3b3

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
idle memory utilization +0.13 [+0.08, +0.17] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.11 [-0.14, +0.35] 1 Logs
quality_gate_idle memory utilization +0.06 [+0.02, +0.11] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.06 [-0.07, +0.18] 1 Logs bounds checks dashboard
otel_to_otel_logs ingress throughput +0.03 [-0.77, +0.84] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.21, +0.24] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.33, +0.36] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.18, +0.18] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.09, +0.09] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.04 [-0.53, +0.44] 1 Logs
basic_py_check % cpu utilization -0.09 [-2.82, +2.65] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.11 [-0.83, +0.61] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.45 [-0.50, -0.40] 1 Logs
pycheck_lots_of_tags % cpu utilization -0.47 [-2.98, +2.04] 1 Logs
idle_all_features memory utilization -1.37 [-1.50, -1.25] 1 Logs bounds checks dashboard
file_tree memory utilization -2.56 [-2.70, -2.41] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle memory_usage 10/10
idle_all_features memory_usage 10/10
quality_gate_idle memory_usage 10/10
quality_gate_idle_all_features memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@pimlu pimlu marked this pull request as ready for review October 24, 2024 13:45
@pimlu pimlu requested review from a team as code owners October 24, 2024 13:45
@pimlu pimlu requested a review from akarpz October 24, 2024 13:45
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Oct 24, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=47989284 --os-family=ubuntu

Note: This applies to commit cf5c3b3

pkg/ebpf/co_re.go Outdated Show resolved Hide resolved
@akarpz
Copy link
Contributor

akarpz commented Oct 24, 2024

needs a release note (I think this is a good example of a time to include one)

@pimlu pimlu requested a review from a team as a code owner October 24, 2024 18:20
pkg/ebpf/btf.go Outdated Show resolved Hide resolved
pkg/ebpf/btf.go Outdated Show resolved Hide resolved
pkg/ebpf/btf.go Outdated Show resolved Hide resolved
pkg/ebpf/co_re.go Outdated Show resolved Hide resolved
pkg/ebpf/btf.go Outdated Show resolved Hide resolved
@pimlu pimlu force-pushed the sgeipel/flare-btf-rebased branch from 346afdc to 77066ef Compare October 30, 2024 17:52
@github-actions github-actions bot added the long review PR is complex, plan time to review it label Oct 30, 2024
pkg/ebpf/btf.go Outdated Show resolved Hide resolved
pkg/ebpf/btf.go Outdated Show resolved Hide resolved
pkg/ebpf/btf.go Outdated Show resolved Hide resolved
@pimlu pimlu added this to the 7.60.0 milestone Oct 31, 2024
@pimlu
Copy link
Contributor Author

pimlu commented Oct 31, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 31, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 24m.

Use /merge -c to cancel this operation!

@pimlu
Copy link
Contributor Author

pimlu commented Oct 31, 2024

/remove

@dd-devflow
Copy link

dd-devflow bot commented Oct 31, 2024

🚂 Devflow: /remove

@dd-devflow
Copy link

dd-devflow bot commented Oct 31, 2024

⚠️ MergeQueue: This merge request build was cancelled

This merge request build was cancelled

If you need support, contact us on Slack #devflow!

@pimlu
Copy link
Contributor Author

pimlu commented Oct 31, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 31, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 9a5c925 into main Oct 31, 2024
294 of 297 checks passed
@dd-mergequeue dd-mergequeue bot deleted the sgeipel/flare-btf-rebased branch October 31, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/system-probe long review PR is complex, plan time to review it team/networks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants