-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(agent6): Repair the CI build #30234
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouetz
added
changelog/no-changelog
qa/no-code-change
No code change in Agent code requiring validation
labels
Oct 17, 2024
chouetz
commented
Oct 17, 2024
"JMXFETCH_VERSION": "0.49.0", | ||
"JMXFETCH_HASH": "b5c2c3ff27603f469bb11961d559f1154887963e02b9d70d5f1fc7efa527a486", | ||
"MACOS_BUILD_VERSION": "7.53.x", | ||
"MACOS_BUILD_VERSION": "nschweitzer/master", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't support macos in agent6, so I fixed this temporarily but will decommission macos later.
kacper-murzyn
approved these changes
Oct 17, 2024
This reverts commit aa3d5d0.
alexn-dd
approved these changes
Oct 18, 2024
Pythyu
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Several fixes to have a (partial) valid build on the
6.53.x
branch:Motivation
Have capacity to release an Agent 6: have a working agent6 branch
Describe how to test/QA your changes
Validate agent6 related jobs are 🟢
Possible Drawbacks / Trade-offs
test-infra
related to this change on a dedicated PR.Additional Notes