Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discovery: move container ID log level to INFO #30185

Closed
wants to merge 1 commit into from

Conversation

Yumasi
Copy link
Member

@Yumasi Yumasi commented Oct 16, 2024

What does this PR do?

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Oct 16, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=47315625 --os-family=ubuntu

Note: This applies to commit f197613

Copy link

cit-pr-commenter bot commented Oct 16, 2024

Regression Detector

Regression Detector Results

Run ID: f381ea24-a00c-4719-973c-da43a3226d08 Metrics dashboard Target profiles

Baseline: a5b503f
Comparison: f197613

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +1.31 [+0.59, +2.02] 1 Logs
quality_gate_idle_all_features memory utilization +1.04 [+0.92, +1.17] 1 Logs bounds checks dashboard
file_tree memory utilization +1.01 [+0.87, +1.15] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.58 [+0.53, +0.64] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.38 [-0.11, +0.86] 1 Logs
pycheck_lots_of_tags % cpu utilization +0.26 [-2.26, +2.77] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.06 [-0.12, +0.24] 1 Logs
idle_all_features memory utilization +0.01 [-0.10, +0.13] 1 Logs bounds checks dashboard
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.00 [-0.34, +0.34] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.23, +0.21] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.12, +0.10] 1 Logs
otel_to_otel_logs ingress throughput -0.11 [-0.91, +0.70] 1 Logs
idle memory utilization -0.13 [-0.18, -0.08] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput -0.24 [-0.48, +0.00] 1 Logs
quality_gate_idle memory utilization -0.44 [-0.50, -0.38] 1 Logs bounds checks dashboard
basic_py_check % cpu utilization -1.21 [-3.99, +1.57] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle memory_usage 10/10
idle_all_features memory_usage 10/10
quality_gate_idle memory_usage 10/10
quality_gate_idle_all_features memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@Yumasi Yumasi force-pushed the guillaume.pagnoux/info-log-level-container-id branch from 402ec88 to f197613 Compare October 24, 2024 09:03
@Yumasi Yumasi closed this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant