Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new AgentMajorVersion parameter in the e2e tests #30172

Merged
merged 4 commits into from
Oct 24, 2024

Conversation

FlorentClarret
Copy link
Member

@FlorentClarret FlorentClarret commented Oct 16, 2024

What does this PR do?

Use the new AgentMajorVersion parameter in the e2e tests

Motivation

DataDog/test-infra-definitions#1192

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

Relates to DataDog/test-infra-definitions#1192

https://datadoghq.atlassian.net/browse/ADXT-680

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Oct 16, 2024

[Fast Unit Tests Report]

On pipeline 47205431 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

cit-pr-commenter bot commented Oct 16, 2024

Regression Detector

Regression Detector Results

Run ID: a070f905-23c9-4996-8f09-4d686a56c816 Metrics dashboard Target profiles

Baseline: 1b238ec
Comparison: 78adf6a

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +1.14 [-1.59, +3.87] 1 Logs
otel_to_otel_logs ingress throughput +0.58 [-0.23, +1.39] 1 Logs
idle_all_features memory utilization +0.53 [+0.43, +0.63] 1 Logs bounds checks dashboard
uds_dogstatsd_to_api_cpu % cpu utilization +0.49 [-0.22, +1.21] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.45 [-0.04, +0.94] 1 Logs
quality_gate_idle_all_features memory utilization +0.43 [+0.32, +0.54] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.09 [+0.05, +0.13] 1 Logs
quality_gate_idle memory utilization +0.03 [-0.01, +0.07] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.03 [-0.22, +0.28] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.07, +0.08] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.00 [-0.18, +0.18] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.00 [-0.33, +0.33] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.24, +0.21] 1 Logs
file_tree memory utilization -0.04 [-0.17, +0.08] 1 Logs
idle memory utilization -0.26 [-0.31, -0.21] 1 Logs bounds checks dashboard
pycheck_lots_of_tags % cpu utilization -0.50 [-3.01, +2.02] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle memory_usage 10/10
idle_all_features memory_usage 10/10
quality_gate_idle memory_usage 10/10
quality_gate_idle_all_features memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Oct 22, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=47205431 --os-family=ubuntu

Note: This applies to commit 78adf6a

@FlorentClarret FlorentClarret force-pushed the florentclarret/e2e-agent6-param branch from fc7fb36 to 78adf6a Compare October 23, 2024 07:07
@FlorentClarret FlorentClarret marked this pull request as ready for review October 24, 2024 08:13
@FlorentClarret FlorentClarret requested review from a team as code owners October 24, 2024 08:13
Copy link
Contributor

@f4usto f4usto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, placed only a question

test/new-e2e/pkg/runner/configmap.go Show resolved Hide resolved
@FlorentClarret
Copy link
Member Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 24, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 84a393a into main Oct 24, 2024
375 checks passed
@dd-mergequeue dd-mergequeue bot deleted the florentclarret/e2e-agent6-param branch October 24, 2024 10:04
@github-actions github-actions bot added this to the 7.60.0 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-devx-loops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants