Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vault): Migrate Agent e2e configuration #30170

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

chouetz
Copy link
Member

@chouetz chouetz commented Oct 16, 2024

What does this PR do?

Migrate ssm params to vault

Motivation

https://datadoghq.atlassian.net/browse/ACIX-447

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@chouetz chouetz requested review from a team as code owners October 16, 2024 11:47
@chouetz chouetz added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Oct 16, 2024
@agent-platform-auto-pr
Copy link
Contributor

Gitlab CI Configuration Changes

⚠️ Diff too large to display on Github.

Changes Summary

Removed Modified Added Renamed
0 132 0 0

ℹ️ Diff available in the job log.

Copy link
Member

@L3n41c L3n41c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the definitions of the AGENT_QA_PROFILE, SSH_PUBLIC_KEY_RSA and SSH_KEY_RSA variables now be deleted from .gitlab-ci.yml line 204, 255 and 256 ?

@chouetz
Copy link
Member Author

chouetz commented Oct 16, 2024

Can the definitions of the AGENT_QA_PROFILE, SSH_PUBLIC_KEY_RSA and SSH_KEY_RSA variables now be deleted from .gitlab-ci.yml line 204, 255 and 256 ?

@L3n41c I will do a dedicated clean-up PR once all the vault parts will be done

Copy link

Regression Detector

Regression Detector Results

Run ID: aaa1a9f8-ddcf-45db-82d3-b09569715662 Metrics dashboard Target profiles

Baseline: 19c2807
Comparison: cb9370b

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +0.96 [+0.23, +1.69] 1 Logs
idle_all_features memory utilization +0.37 [+0.27, +0.46] 1 Logs bounds checks dashboard
basic_py_check % cpu utilization +0.21 [-2.44, +2.85] 1 Logs
otel_to_otel_logs ingress throughput +0.19 [-0.61, +0.99] 1 Logs
idle memory utilization +0.15 [+0.11, +0.20] 1 Logs bounds checks dashboard
file_to_blackhole_500ms_latency egress throughput +0.02 [-0.23, +0.27] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.02 [-0.46, +0.50] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.10, +0.11] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.02 [-0.25, +0.21] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.02 [-0.36, +0.31] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.03 [-0.21, +0.15] 1 Logs
pycheck_lots_of_tags % cpu utilization -0.19 [-2.73, +2.35] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.43 [-0.48, -0.38] 1 Logs
file_tree memory utilization -1.30 [-1.42, -1.18] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle memory_usage 10/10
idle_all_features memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@chouetz
Copy link
Member Author

chouetz commented Oct 17, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 17, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 25m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 152a0e7 into main Oct 17, 2024
303 checks passed
@dd-mergequeue dd-mergequeue bot deleted the nschweitzer/vault_ssh branch October 17, 2024 10:27
@github-actions github-actions bot added this to the 7.60.0 milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants