[ASCII-2357]: Do not use %w when the error is nil

[ogaca-dd]

What does this PR do?

This PR removes the formatting %w when the error is nil.

Motivation

Displaying an nil error when using %w result in a not so great message %!w(<nil>)

Describe how to test/QA your changes

Done by running unit tests.

Possible Drawbacks / Trade-offs

Additional Notes

[agent-platform-auto-pr]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=46807301 --os-family=ubuntu

Note: This applies to commit e7bd0ea

[julien-lebot]

💭 thought: ‏ Shouldn't that be

Suggested change

	if addDDAgentUser(ctx) != nil {
	if err = addDDAgentUser(ctx); err != nil {
	return fmt.Errorf("error creating dd-agent user: %w", err)
	}

instead?

[Hitsuji-M]

Suggested change

	if addDDAgentUser(ctx) != nil {
	if err = addDDAgentUser(ctx); err != nil {

Keeping track of the error would be good. (sorry for previous comments, I misread)

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Run ID: 3b4d4456-908a-425d-8fcc-3dc84d1d8381 Metrics dashboard Target profiles

Baseline: 152a0e7
Comparison: e7bd0ea

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+2.11	[+1.38, +2.84]	1	Logs
➖	basic_py_check	% cpu utilization	+1.21	[-1.52, +3.95]	1	Logs
➖	idle	memory utilization	+0.66	[+0.59, +0.72]	1	Logs bounds checks dashboard
➖	file_to_blackhole_1000ms_latency	egress throughput	+0.35	[-0.14, +0.84]	1	Logs
➖	file_to_blackhole_500ms_latency	egress throughput	+0.11	[-0.13, +0.36]	1	Logs
➖	file_to_blackhole_0ms_latency	egress throughput	+0.00	[-0.33, +0.34]	1	Logs
➖	file_to_blackhole_100ms_latency	egress throughput	+0.00	[-0.22, +0.23]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.10, +0.09]	1	Logs
➖	file_to_blackhole_300ms_latency	egress throughput	-0.08	[-0.26, +0.11]	1	Logs
➖	otel_to_otel_logs	ingress throughput	-0.27	[-1.07, +0.54]	1	Logs
➖	idle_all_features	memory utilization	-0.56	[-0.68, -0.45]	1	Logs bounds checks dashboard
➖	pycheck_lots_of_tags	% cpu utilization	-0.69	[-3.19, +1.82]	1	Logs
➖	file_tree	memory utilization	-0.76	[-0.89, -0.63]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.80	[-0.85, -0.75]	1	Logs

Bounds Checks

perf	experiment	bounds_check_name	replicates_passed
❌	idle	memory_usage	9/10
✅	file_to_blackhole_0ms_latency	memory_usage	10/10
✅	file_to_blackhole_1000ms_latency	memory_usage	10/10
✅	file_to_blackhole_100ms_latency	memory_usage	10/10
✅	file_to_blackhole_300ms_latency	memory_usage	10/10
✅	file_to_blackhole_500ms_latency	memory_usage	10/10
✅	idle_all_features	memory_usage	10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[ogaca-dd]

I have pushed wrong commits to this branch and remove them (force-pushed)

[ogaca-dd]

/merge

[dd-devflow]

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!