Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SBOM] Removed prefix in overlayfs mounts #30029

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

lebauce
Copy link
Contributor

@lebauce lebauce commented Oct 10, 2024

What does this PR do?

Sanitize overlayfs upper, lower and work dirs so that they are reachable from the agent container.

Motivation

On some environments (minikube + kvm2 + containerd for instance), the directories
uses for overlayfs are prefixed with "/mnt/vda1". These are not accessible from the agent container
so we strip it from the paths.

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@lebauce lebauce requested a review from a team as a code owner October 10, 2024 17:49
@lebauce lebauce force-pushed the lebauce/fix-snapshotter branch from 295712e to 249955e Compare October 11, 2024 08:52
@lebauce lebauce requested a review from a team as a code owner October 11, 2024 08:52
@lebauce lebauce added this to the 7.60.0 milestone Oct 11, 2024
@lebauce lebauce force-pushed the lebauce/fix-snapshotter branch from 249955e to b7806b1 Compare October 11, 2024 08:57
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Oct 11, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=46706881 --os-family=ubuntu

Note: This applies to commit 7a48a59

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Oct 11, 2024

[Fast Unit Tests Report]

On pipeline 46706881 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

Copy link

cit-pr-commenter bot commented Oct 11, 2024

Regression Detector

Regression Detector Results

Run ID: 549ce148-3d3d-47d9-bb94-9e4cc08bfa32 Metrics dashboard Target profiles

Baseline: ddc0fd7
Comparison: 7a48a59

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
pycheck_lots_of_tags % cpu utilization +2.13 [-0.46, +4.72] 1 Logs
idle memory utilization +0.19 [+0.14, +0.23] 1 Logs bounds checks dashboard
basic_py_check % cpu utilization +0.18 [-2.55, +2.92] 1 Logs
file_to_blackhole_300ms_latency egress throughput +0.08 [-0.10, +0.26] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.33, +0.35] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.09, +0.09] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.23, +0.22] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.06 [-0.31, +0.18] 1 Logs
file_tree memory utilization -0.10 [-0.24, +0.03] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.18 [-0.67, +0.31] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.20 [-0.92, +0.52] 1 Logs
idle_all_features memory utilization -0.31 [-0.40, -0.21] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.52 [-0.59, -0.45] 1 Logs
otel_to_otel_logs ingress throughput -0.82 [-1.62, -0.02] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle memory_usage 10/10
idle_all_features memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@lebauce lebauce force-pushed the lebauce/fix-snapshotter branch from d1875b9 to 7a48a59 Compare October 16, 2024 11:56
@lebauce
Copy link
Contributor Author

lebauce commented Oct 17, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 17, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 24m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 0a96521 into main Oct 17, 2024
221 checks passed
@dd-mergequeue dd-mergequeue bot deleted the lebauce/fix-snapshotter branch October 17, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants