-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(linter): Return empty object in early exit #29939
Conversation
[Fast Unit Tests Report] On pipeline 46063283 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
/merge |
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
Regression DetectorRegression Detector ResultsRun ID: 0b4dd17-7d6d-4010-b798-353b3ff57883 Metrics dashboard Target profiles Baseline: 5158dc6 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | file_tree | memory utilization | +1.89 | [+1.76, +2.02] | 1 | Logs |
➖ | idle | memory utilization | +0.78 | [+0.73, +0.83] | 1 | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | +0.49 | [-2.00, +2.99] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.10, +0.10] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.03 | [-0.83, +0.78] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.33 | [-1.07, +0.41] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.66 | [-0.72, -0.61] | 1 | Logs |
➖ | idle_all_features | memory utilization | -2.26 | [-2.37, -2.15] | 1 | Logs |
➖ | basic_py_check | % cpu utilization | -2.35 | [-5.00, +0.29] | 1 | Logs |
Bounds Checks
perf | experiment | bounds_check_name | replicates_passed |
---|---|---|---|
✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
❌ MergeQueue: The build pipeline failed for this merge request Build pipeline failed for 1c36f69 What to do next?
If you need support, contact us on Slack #devflow with those details! |
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
Return empty object in early exit
Motivation
Fix failure in case of early exit
Describe how to test/QA your changes
No test yet
Possible Drawbacks / Trade-offs
Additional Notes