do not recalculate global entity id as string on each call #29934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adel121
added
kind/enhancement
component/tagger
changelog/no-changelog
qa/done
davidor
approved these changes
Oct 8, 2024
|
/merge |
|
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=46058509 --os-family=ubuntuNote: This applies to commit 98d0eb6 |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
dd-mergequeue
bot
deleted the
adelhajhassan/avoid_recalculating_global_entityid_as_string_each_time
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR performs an optimisation by avoiding calculating global tagger entity id as string on each call.
This change calculates the id as a string only once, and returns the string on each call.
Motivation
Optimise CPU usage and avoid regression.
CPU impact visible in APM Profiles:
Describe how to test/QA your changes
No need for QA, we already have E2E and unit tests.
Possible Drawbacks / Trade-offs
None
Additional Notes