Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

usm: kafka: Use intern.StringInterner instead of manual implementation #29844

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

guyarb
Copy link
Contributor

@guyarb guyarb commented Oct 7, 2024

What does this PR do?

Uses intern.StringInterner for string interning, instead of our own implementation.

Motivation

  1. Prefer code reuse.
  2. The package handles better the lifecycle of the shared strings.

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@guyarb guyarb added changelog/no-changelog team/usm The USM team qa/done QA done before merge and regressions are covered by tests labels Oct 7, 2024
Prefer code reuse.
The package handles better the lifecycle of the shared strings.
@guyarb guyarb force-pushed the guy.arbitman/USMON-1251-kafka-interner branch from d94c34d to a946467 Compare October 7, 2024 10:58
@pr-commenter
Copy link

pr-commenter bot commented Oct 7, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=45944480 --os-family=ubuntu

Note: This applies to commit a946467

Copy link

Regression Detector

Regression Detector Results

Run ID: b13fa1bf-739a-4b91-b798-de66d3407e88 Metrics dashboard Target profiles

Baseline: 7015f9b
Comparison: a946467

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_tree memory utilization +1.18 [+1.08, +1.28] 1 Logs
tcp_syslog_to_blackhole ingress throughput +1.01 [+0.96, +1.06] 1 Logs
otel_to_otel_logs ingress throughput +0.12 [-0.68, +0.92] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.12, +0.10] 1 Logs
basic_py_check % cpu utilization -0.57 [-3.27, +2.12] 1 Logs
idle_all_features memory utilization -0.85 [-0.99, -0.72] 1 Logs
idle memory utilization -0.89 [-0.95, -0.84] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.24 [-1.97, -0.50] 1 Logs
pycheck_lots_of_tags % cpu utilization -1.49 [-3.92, +0.94] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@guyarb guyarb marked this pull request as ready for review October 8, 2024 10:31
@guyarb guyarb requested a review from a team as a code owner October 8, 2024 10:31
@guyarb
Copy link
Contributor Author

guyarb commented Oct 8, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 8, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 24m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 5158dc6 into main Oct 8, 2024
285 checks passed
@dd-mergequeue dd-mergequeue bot deleted the guy.arbitman/USMON-1251-kafka-interner branch October 8, 2024 11:29
@github-actions github-actions bot added this to the 7.60.0 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe qa/done QA done before merge and regressions are covered by tests team/usm The USM team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants