[AMLII-2060] Add more robust error handling for files

[soberpeach]

What does this PR do?

Adds more robust error handling for files where settings are improperly set or read incorrectly.

Motivation

Previous changes induced a panic in the agent when integrations_logs_disk_ratio was read or set improperly, this change mitigates that.

Describe how to test/QA your changes

Since this is a fix, just maake sure the agent runs correctly and all tests pass.

Possible Drawbacks / Trade-offs

N/A

Additional Notes

[pr-commenter]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=45887287 --os-family=ubuntu

Note: This applies to commit 306c6c8

[cit-pr-commenter]

Regression Detector

Regression Detector Results

Run ID: 5c7bcc6a-32ca-4f2c-8430-efda67544c51 Metrics dashboard Target profiles

Baseline: 66190f7
Comparison: 66190f7

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	pycheck_lots_of_tags	% cpu utilization	+2.16	[-0.32, +4.65]	1	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	+0.61	[+0.56, +0.66]	1	Logs
➖	basic_py_check	% cpu utilization	+0.52	[-2.13, +3.18]	1	Logs
➖	file_tree	memory utilization	+0.38	[+0.25, +0.50]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.09	[-0.63, +0.82]	1	Logs
➖	idle	memory utilization	+0.05	[+0.00, +0.09]	1	Logs
➖	idle_all_features	memory utilization	+0.04	[-0.06, +0.13]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.01	[-0.11, +0.13]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	otel_to_otel_logs	ingress throughput	-0.34	[-1.15, +0.46]	1	Logs

Bounds Checks

perf	experiment	bounds_check_name	replicates_passed
✅	idle	memory_usage	10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[soberpeach]

/merge

[dd-devflow]

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

[soberpeach]

/merge

[dd-devflow]

❌ MergeQueue

PR already in the queue with status in_progress

If you need support, contact us on Slack #devflow with those details!

[soberpeach]

/merge

[dd-devflow]

❌ MergeQueue

PR already in the queue with status in_progress

If you need support, contact us on Slack #devflow with those details!