Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NTWK-557] Fix NPM sendpage probes in openSUSE 15rc6 #29659

Merged
merged 6 commits into from
Oct 2, 2024

Conversation

pimlu
Copy link
Contributor

@pimlu pimlu commented Sep 30, 2024

What does this PR do?

Fixes an issue with openSUSE 15 RC 6 where the eBPF tracer wouldn't to start due to a failed validation of the tcp_sendpage probe.

Motivation

Discovered via inbound issue from customer.

Describe how to test/QA your changes

Install the RPM for this branch in an openSUSE VM and start up system-probe via sudo /opt/datadog-agent/embedded/bin/system-probe run. It should not yield the error related to tcp_sendpage anymore.

In addition, I ran the KMT alien tests on openSUSE via the following: (sles15rc6.json is the alien config pointing to SSH for the VM)

inv -e kmt.test --packages=./pkg/network/tracer --run TestTracerSuite/prebuilt/TestTCPRTT --alien-vms=/Users/stuart.geipel/Documents/aliens/sles15rc6.json

With this change, everything but TestTracerSuite/prebuilt/TestTCPRTT passes which is an unrelated flake of offset guessing in prebuilt.

Possible Drawbacks / Trade-offs

Additional Notes

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Sep 30, 2024

[Fast Unit Tests Report]

On pipeline 45604583 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@pr-commenter
Copy link

pr-commenter bot commented Sep 30, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=45604583 --os-family=ubuntu

Note: This applies to commit 821ec00

@pimlu pimlu force-pushed the stuart.geipel/fix-opensuse-15rc6 branch from c08e82f to 7c6e412 Compare September 30, 2024 16:33
@pr-commenter
Copy link

pr-commenter bot commented Sep 30, 2024

Regression Detector

Regression Detector Results

Run ID: bcb0ff1e-ffcd-4aa8-997d-a575603eafef Metrics dashboard Target profiles

Baseline: 7825aa7
Comparison: 821ec00

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
otel_to_otel_logs ingress throughput +0.65 [-0.16, +1.46] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.08, +0.07] 1 Logs
pycheck_lots_of_tags % cpu utilization -0.15 [-2.69, +2.39] 1 Logs
file_tree memory utilization -0.41 [-0.50, -0.33] 1 Logs
tcp_syslog_to_blackhole ingress throughput -0.60 [-0.65, -0.55] 1 Logs
idle memory utilization -0.69 [-0.74, -0.65] 1 Logs
idle_all_features memory utilization -0.98 [-1.05, -0.92] 1 Logs
basic_py_check % cpu utilization -1.78 [-4.50, +0.94] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -2.16 [-2.90, -1.41] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@pimlu pimlu changed the title [NTWK-557] Fix NPM probes in OpenSUSE 15rc6 [NTWK-557] Fix NPM probes in openSUSE 15rc6 Sep 30, 2024
@pimlu pimlu marked this pull request as ready for review September 30, 2024 17:57
@pimlu pimlu requested review from a team as code owners September 30, 2024 17:57
@pimlu pimlu requested a review from AmitaiBl September 30, 2024 17:57
@pimlu pimlu changed the title [NTWK-557] Fix NPM probes in openSUSE 15rc6 [NTWK-557] Fix NPM sendpage probes in openSUSE 15rc6 Sep 30, 2024
@akarpz
Copy link
Contributor

akarpz commented Sep 30, 2024

any luck with potentially adding this to KMT so we have regression tests?

pkg/network/tracer/connection/kprobe/config.go Outdated Show resolved Hide resolved
pkg/network/tracer/connection/kprobe/config.go Outdated Show resolved Hide resolved
pkg/network/tracer/connection/kprobe/config.go Outdated Show resolved Hide resolved
@pimlu
Copy link
Contributor Author

pimlu commented Sep 30, 2024

any luck with potentially adding this to KMT so we have regression tests?

Doesn't sound like it will be introduced right away due to cost concerns. https://dd.slack.com/archives/C0424HA1SJK/p1727383805482329?thread_ts=1727382966.685849&cid=C0424HA1SJK
It seems they evaluate KMT based on usage percentage from customers. Maybe once most customers are using RC6 instead of RC5, they will switch that stack in KMT to use RC6?

But regardless, it would be nice to just have these OSes available but "disabled" if cost is the concern.

Copy link
Contributor

@neko-dd neko-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fix and suggestion, otherwise LGTM

@pimlu pimlu added this to the 7.59.0 milestone Oct 1, 2024
@pimlu pimlu added the backport/7.58.x Automatically create a backport PR to 7.58.x label Oct 1, 2024
@pimlu pimlu force-pushed the stuart.geipel/fix-opensuse-15rc6 branch from 1b20dc4 to 897b495 Compare October 2, 2024 13:29
@pimlu pimlu force-pushed the stuart.geipel/fix-opensuse-15rc6 branch from 897b495 to 821ec00 Compare October 2, 2024 13:30
@pimlu
Copy link
Contributor Author

pimlu commented Oct 2, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 2, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 27m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 3dd31a5 into main Oct 2, 2024
303 checks passed
@dd-mergequeue dd-mergequeue bot deleted the stuart.geipel/fix-opensuse-15rc6 branch October 2, 2024 15:12
agent-platform-auto-pr bot pushed a commit that referenced this pull request Oct 2, 2024
Co-authored-by: Sandra (neko) <[email protected]>
(cherry picked from commit 3dd31a5)
wdhif pushed a commit that referenced this pull request Oct 2, 2024
grantseltzer pushed a commit that referenced this pull request Oct 2, 2024
grantseltzer pushed a commit that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/7.58.x Automatically create a backport PR to 7.58.x component/system-probe team/networks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants