-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NTWK-557] Fix NPM sendpage probes in openSUSE 15rc6 #29659
Conversation
[Fast Unit Tests Report] On pipeline 45604583 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=45604583 --os-family=ubuntu Note: This applies to commit 821ec00 |
c08e82f
to
7c6e412
Compare
Regression DetectorRegression Detector ResultsRun ID: bcb0ff1e-ffcd-4aa8-997d-a575603eafef Metrics dashboard Target profiles Baseline: 7825aa7 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | otel_to_otel_logs | ingress throughput | +0.65 | [-0.16, +1.46] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.08, +0.07] | 1 | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | -0.15 | [-2.69, +2.39] | 1 | Logs |
➖ | file_tree | memory utilization | -0.41 | [-0.50, -0.33] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -0.60 | [-0.65, -0.55] | 1 | Logs |
➖ | idle | memory utilization | -0.69 | [-0.74, -0.65] | 1 | Logs |
➖ | idle_all_features | memory utilization | -0.98 | [-1.05, -0.92] | 1 | Logs |
➖ | basic_py_check | % cpu utilization | -1.78 | [-4.50, +0.94] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -2.16 | [-2.90, -1.41] | 1 | Logs |
Bounds Checks
perf | experiment | bounds_check_name | replicates_passed |
---|---|---|---|
✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
any luck with potentially adding this to KMT so we have regression tests? |
Doesn't sound like it will be introduced right away due to cost concerns. https://dd.slack.com/archives/C0424HA1SJK/p1727383805482329?thread_ts=1727382966.685849&cid=C0424HA1SJK But regardless, it would be nice to just have these OSes available but "disabled" if cost is the concern. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo fix and suggestion, otherwise LGTM
releasenotes/notes/fix-opensuse-15rc6-sendpage-11ba41034deaa721.yaml
Outdated
Show resolved
Hide resolved
1b20dc4
to
897b495
Compare
897b495
to
821ec00
Compare
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
Co-authored-by: Sandra (neko) <[email protected]> (cherry picked from commit 3dd31a5)
Co-authored-by: Sandra (neko) <[email protected]>
Co-authored-by: Sandra (neko) <[email protected]>
Co-authored-by: Sandra (neko) <[email protected]>
What does this PR do?
Fixes an issue with openSUSE 15 RC 6 where the eBPF tracer wouldn't to start due to a failed validation of the tcp_sendpage probe.
Motivation
Discovered via inbound issue from customer.
Describe how to test/QA your changes
Install the RPM for this branch in an openSUSE VM and start up system-probe via
sudo /opt/datadog-agent/embedded/bin/system-probe run
. It should not yield the error related to tcp_sendpage anymore.In addition, I ran the KMT alien tests on openSUSE via the following: (sles15rc6.json is the alien config pointing to SSH for the VM)
With this change, everything but
TestTracerSuite/prebuilt/TestTCPRTT
passes which is an unrelated flake of offset guessing in prebuilt.Possible Drawbacks / Trade-offs
Additional Notes