-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dbm] bump go-sqllexer to v0.0.15 with new KeepJsonPath option #29655
Conversation
fe64b82
to
92a8655
Compare
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=45439799 --os-family=ubuntu Note: This applies to commit ba2149d |
Regression DetectorRegression Detector ResultsRun ID: fcd33610-d47a-48ce-9e43-0c6a6e360f01 Metrics dashboard Target profiles Baseline: e31532d Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | pycheck_lots_of_tags | % cpu utilization | +1.81 | [-0.68, +4.31] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | +1.53 | [+0.72, +2.34] | 1 | Logs |
➖ | file_tree | memory utilization | +0.70 | [+0.61, +0.78] | 1 | Logs |
➖ | idle | memory utilization | +0.37 | [+0.33, +0.41] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.11, +0.10] | 1 | Logs |
➖ | idle_all_features | memory utilization | -0.30 | [-0.37, -0.23] | 1 | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.99 | [-1.73, -0.25] | 1 | Logs |
➖ | basic_py_check | % cpu utilization | -1.00 | [-3.73, +1.73] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -1.35 | [-1.44, -1.26] | 1 | Logs |
Bounds Checks
perf | experiment | bounds_check_name | replicates_passed |
---|---|---|---|
✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
This PR bumps
go-sqllexer
to v0.0.15 with new obfuscation optionKeepJSONPath
. The new config optionKeepJsonPath
allows users to control whether JSON paths following JSON operators in SQL statements should be obfuscated. By default, these paths are treated as literals and are obfuscated to?
.For example, in the SQL statements
The JSON path
name
following the JSON operator -> would normally be obfuscated to?
, resulting in:With the
KeepJSONPath
option enabled, users can skip this obfuscation, preserving the original JSON pathname
in the query.By default,
KeepJSONPath
is set to false for backward compatibility and JSON paths are treated as literals and are obfuscated to?
.Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes