Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dbm] bump go-sqllexer to v0.0.15 with new KeepJsonPath option #29655

Merged
merged 3 commits into from
Oct 2, 2024

Conversation

lu-zhengda
Copy link
Contributor

@lu-zhengda lu-zhengda commented Sep 30, 2024

What does this PR do?

This PR bumps go-sqllexer to v0.0.15 with new obfuscation option KeepJSONPath. The new config option KeepJsonPath allows users to control whether JSON paths following JSON operators in SQL statements should be obfuscated. By default, these paths are treated as literals and are obfuscated to ?.

For example, in the SQL statements

-- Extracts JSON object field with the given key
SELECT data::jsonb -> 'name'

The JSON path name following the JSON operator -> would normally be obfuscated to ?, resulting in:

SELECT data::jsonb -> ?

With the KeepJSONPath option enabled, users can skip this obfuscation, preserving the original JSON path name in the query.

By default, KeepJSONPath is set to false for backward compatibility and JSON paths are treated as literals and are obfuscated to ?.

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@lu-zhengda lu-zhengda requested review from a team as code owners September 30, 2024 15:25
@github-actions github-actions bot added the team/opentelemetry OpenTelemetry team label Sep 30, 2024
@pr-commenter
Copy link

pr-commenter bot commented Sep 30, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=45439799 --os-family=ubuntu

Note: This applies to commit ba2149d

@pr-commenter
Copy link

pr-commenter bot commented Sep 30, 2024

Regression Detector

Regression Detector Results

Run ID: fcd33610-d47a-48ce-9e43-0c6a6e360f01 Metrics dashboard Target profiles

Baseline: e31532d
Comparison: ba2149d

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
pycheck_lots_of_tags % cpu utilization +1.81 [-0.68, +4.31] 1 Logs
otel_to_otel_logs ingress throughput +1.53 [+0.72, +2.34] 1 Logs
file_tree memory utilization +0.70 [+0.61, +0.78] 1 Logs
idle memory utilization +0.37 [+0.33, +0.41] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.11, +0.10] 1 Logs
idle_all_features memory utilization -0.30 [-0.37, -0.23] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization -0.99 [-1.73, -0.25] 1 Logs
basic_py_check % cpu utilization -1.00 [-3.73, +1.73] 1 Logs
tcp_syslog_to_blackhole ingress throughput -1.35 [-1.44, -1.26] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@lu-zhengda
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 2, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 27m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 8617bfe into main Oct 2, 2024
234 checks passed
@dd-mergequeue dd-mergequeue bot deleted the zhengda.lu/json branch October 2, 2024 15:05
@github-actions github-actions bot added this to the 7.59.0 milestone Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/opentelemetry OpenTelemetry team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants