feat(security): Migrate some credentials to vault #29626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouetz
added
changelog/no-changelog
qa/no-code-change
CelianR
reviewed
Sep 27, 2024
Gitlab CI Configuration Changes
|
| Removed | Modified | Added | Renamed |
|---|---|---|---|
| 0 | 10 | 0 | 0 |
ℹ️ Diff available in the job log.
Regression DetectorRegression Detector ResultsRun ID: 7bc495e0-a5cc-41a6-87a8-33484fd64a6a Metrics dashboard Target profiles Baseline: ad9b1c3 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.50 | [-0.24, +1.23] | 1 | Logs |
| ➖ | idle | memory utilization | +0.23 | [+0.18, +0.27] | 1 | Logs |
| ➖ | idle_all_features | memory utilization | +0.17 | [+0.11, +0.24] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.13 | [-0.68, +0.94] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.10, +0.09] | 1 | Logs |
| ➖ | file_tree | memory utilization | -0.17 | [-0.25, -0.08] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | -0.62 | [-0.66, -0.58] | 1 | Logs |
| ➖ | basic_py_check | % cpu utilization | -0.67 | [-3.29, +1.96] | 1 | Logs |
| ➖ | pycheck_lots_of_tags | % cpu utilization | -1.39 | [-3.90, +1.11] | 1 | Logs |
Bounds Checks
| perf | experiment | bounds_check_name | replicates_passed |
|---|---|---|---|
| ✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
|
[Fast Unit Tests Report] On pipeline 45311345 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
CelianR
approved these changes
Sep 30, 2024
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
wdhif
pushed a commit
that referenced
this pull request
Sep 30, 2024
wdhif
pushed a commit
that referenced
this pull request
Oct 2, 2024
grantseltzer
pushed a commit
that referenced
this pull request
Oct 2, 2024
grantseltzer
pushed a commit
that referenced
this pull request
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
First wave of credentials migration to vault:
datadog-agent-macos-buildbridge, one for write access ondatadog-agent)Motivation
Vault is the recommended storage for secrets used in k8s gitlab runners.
ACIX-354
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes