Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Remove the macOS Github Actions linter job #29575

Merged
merged 1 commit into from
Sep 26, 2024
Merged

[CI] Remove the macOS Github Actions linter job #29575

merged 1 commit into from
Sep 26, 2024

Conversation

amenasria
Copy link
Contributor

What does this PR do?

This PR removes the macOS GHA job.

Motivation

  • We're getting rate-limited by Github when running lint, tests and build jobs with the current Github plan.
  • The lint job already runs on the new macOS Gitlab runners, so we can replace the GHA one.

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@amenasria amenasria added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-devx-infra labels Sep 25, 2024
@amenasria amenasria requested a review from a team as a code owner September 25, 2024 19:53
@amenasria
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Sep 26, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit 6dc523c into main Sep 26, 2024
254 checks passed
@dd-mergequeue dd-mergequeue bot deleted the amenasria/switch-macos-linters-from-gha-to-gitlab branch September 26, 2024 07:48
@github-actions github-actions bot added this to the 7.59.0 milestone Sep 26, 2024
grantseltzer pushed a commit that referenced this pull request Oct 2, 2024
@amenasria @grantseltzer
[CI] Remove the macOS Github Actions linter job (#29575)
550fba2
grantseltzer pushed a commit that referenced this pull request Oct 4, 2024
@amenasria @grantseltzer
[CI] Remove the macOS Github Actions linter job (#29575)
f03f924
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CelianR CelianR CelianR approved these changes

Assignees
No one assigned
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/agent-devx-infra
Projects
None yet
Milestone
7.59.0
Development

Successfully merging this pull request may close these issues.
2 participants
@amenasria @CelianR