[NETPATH-297] Update timeout to be per hop instead of per path

[ken-schneider]

What does this PR do?

This changes the behavior of timeout in the configuration of Network path. Previously, the timeout field controlled the timeout for the entire path trace. The default timeout has been updated to be 1000 which translates to 1 second per hop.

Motivation

Other traceroute tools use this to configure their timeouts, some call this value "waittime". In the future this should allow us to more easily change the underlying implementation e.g. running traceroute serially or in parallel without the timeout having different meanings depending on the implementation.

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[pr-commenter]

Regression Detector

Regression Detector Results

Run ID: 9e75744c-2250-4a90-aa11-a801e822150c Metrics dashboard Target profiles

Baseline: d99d8f2
Comparison: b9ed93d

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	trials	links
➖	tcp_syslog_to_blackhole	ingress throughput	+1.69	[-11.09, +14.46]	1	Logs
➖	file_tree	memory utilization	+0.83	[+0.78, +0.88]	1	Logs
➖	idle	memory utilization	+0.29	[+0.26, +0.33]	1	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]	1	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	-0.00	[-0.01, +0.01]	1	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	-0.10	[-0.88, +0.68]	1	Logs
➖	basic_py_check	% cpu utilization	-1.04	[-3.56, +1.49]	1	Logs
➖	otel_to_otel_logs	ingress throughput	-1.08	[-1.89, -0.27]	1	Logs
➖	pycheck_lots_of_tags	% cpu utilization	-1.28	[-3.81, +1.24]	1	Logs

Bounds Checks

perf	experiment	bounds_check_name	replicates_passed
✅	idle	memory_usage	10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[jeremy-hanna]

👍 for ASC owned files

[pr-commenter]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=43676180 --os-family=ubuntu

Note: This applies to commit b9ed93d

[alai97]

Looks good, small copy suggestion.

[alai97]

Suggested change

	## Specifies how much time in milliseconds traceroute should
	## Specifies how much time in milliseconds the traceroute should

[alai97]

Suggested change

	## Specifies how much time in milliseconds traceroute should
	## Specifies how much time in milliseconds the traceroute should

[ken-schneider]

/merge

[dd-devflow]

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!