Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jmx] fix configuration name typo for jmx_restart_interval #2898

Merged
merged 3 commits into from
Jan 16, 2019

Conversation

truthbk
Copy link
Member

@truthbk truthbk commented Jan 16, 2019

What does this PR do?

Fixes a typo by which we were using the wrong config name for jmx_restart_interval, breaking the throttling feature.

Motivation

Throttling behavior not working as expected.

Additional Notes

Anything else we should know when reviewing?

@truthbk truthbk requested a review from a team as a code owner January 16, 2019 20:42
@truthbk truthbk added [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. changelog/no-changelog kind/bug labels Jan 16, 2019
@truthbk truthbk added this to the 6.9.0 milestone Jan 16, 2019
olivielpeau
olivielpeau previously approved these changes Jan 16, 2019
@codecov-io
Copy link

codecov-io commented Jan 16, 2019

Codecov Report

Merging #2898 into master will decrease coverage by 0.16%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2898      +/-   ##
==========================================
- Coverage   57.35%   57.19%   -0.17%     
==========================================
  Files         393      393              
  Lines       25705    25705              
==========================================
- Hits        14744    14701      -43     
- Misses       9988    10035      +47     
+ Partials      973      969       -4
Impacted Files Coverage Δ
pkg/config/config.go 83.4% <100%> (ø) ⬆️
pkg/collector/runner/runner.go 52.63% <0%> (-14.39%) ⬇️
pkg/forwarder/domain_forwarder.go 91.33% <0%> (-1.58%) ⬇️

@truthbk truthbk merged commit d315aaf into master Jan 16, 2019
@truthbk truthbk deleted the jaime/jmxlifecyclefix branch January 16, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog [deprecated] team/agent-core Deprecated. Use metrics-logs / shared-components labels instead.. kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants