discovery: Report RSS #28931
Merged
discovery: Report RSS #28931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the agent check uses the all process list to check if the process is alive or not, but we can use the service list instead, since that also considers open ports. So if a process closes its listening port the service is no longer alive. This also allows to use the extra fields received from system-probe such as RSS and allows the proc usage in the check to be eliminated in the future.
Pass along the information about services' RSS memory received from system-probe to the final telemetry events.
vitkyrka
added
changelog/no-changelog
team/usm
Yumasi
approved these changes
Aug 30, 2024
|
/merge |
|
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Report memory usage (RSS) for discovered services.
Motivation
https://datadoghq.atlassian.net/browse/USMON-1166
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes