Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the appropriate port when redirecting node-agents to leader #2892

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

xvello
Copy link
Contributor

@xvello xvello commented Jan 15, 2019

What does this PR do?

The query port is not available in the request.URL object, making the current redirection code send node-agents on the 443 port.

Assume all DCAs listen on the same port and use the cluster_agent.cmd_port option during redirection.

@xvello xvello force-pushed the xvello/cchecks-missing-port branch from 21b0b39 to 7bd70e4 Compare January 15, 2019 16:38
@codecov-io
Copy link

codecov-io commented Jan 15, 2019

Codecov Report

Merging #2892 into master will decrease coverage by 0.01%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master    #2892      +/-   ##
==========================================
- Coverage   57.37%   57.36%   -0.02%     
==========================================
  Files         393      393              
  Lines       25706    25707       +1     
==========================================
- Hits        14748    14746       -2     
- Misses       9986     9989       +3     
  Partials      972      972
Impacted Files Coverage Δ
pkg/clusteragent/clusterchecks/handler.go 71.77% <0%> (-0.59%) ⬇️
pkg/clusteragent/clusterchecks/api.go 100% <100%> (ø) ⬆️
pkg/logs/input/listener/tailer.go 86% <0%> (-4%) ⬇️
pkg/forwarder/domain_forwarder.go 91.33% <0%> (-1.58%) ⬇️
pkg/secrets/secrets.go 65.04% <0%> (+1.94%) ⬆️

Copy link
Contributor

@CharlyF CharlyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@xvello xvello merged commit 7f6f289 into master Jan 23, 2019
@xvello xvello deleted the xvello/cchecks-missing-port branch January 23, 2019 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants