Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROCS-4228] Add E2E tests in K8s for running the process checks in the core agent #28640

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

daniel-taf
Copy link
Contributor

@daniel-taf daniel-taf commented Aug 21, 2024

What does this PR do?

Add e2e tests in K8s for running the process checks in the core agent. This also enables the process discovery test as the mentioned issue was fixed.

Motivation

PROCS-4228

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

E2E test passes 😃

@pr-commenter
Copy link

pr-commenter bot commented Aug 21, 2024

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=43079603 --os-family=ubuntu

Note: This applies to commit f7f177c

@daniel-taf daniel-taf changed the base branch from main to daniel.tafoya/better-windows-handling August 22, 2024 14:12
@daniel-taf daniel-taf changed the title Add better windows handling Test K8s test Aug 22, 2024
@daniel-taf daniel-taf changed the title Test K8s test Remove skip from K8s test Aug 22, 2024
@pr-commenter
Copy link

pr-commenter bot commented Aug 22, 2024

Regression Detector

Regression Detector Results

Run ID: 2fbda19a-1aa6-4df0-9576-4f7f22dbfdb4 Metrics dashboard Target profiles

Baseline: cbd1883
Comparison: f7f177c

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
basic_py_check % cpu utilization +0.23 [-2.36, +2.81] Logs
otel_to_otel_logs ingress throughput +0.01 [-0.80, +0.82] Logs
uds_dogstatsd_to_api ingress throughput +0.00 [-0.00, +0.00] Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] Logs
idle memory utilization -0.21 [-0.24, -0.18] Logs
pycheck_lots_of_tags % cpu utilization -0.24 [-2.68, +2.19] Logs
file_tree memory utilization -0.43 [-0.49, -0.38] Logs
uds_dogstatsd_to_api_cpu % cpu utilization -1.15 [-2.10, -0.20] Logs
tcp_syslog_to_blackhole ingress throughput -3.63 [-16.51, +9.24] Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Base automatically changed from daniel.tafoya/better-windows-handling to main August 23, 2024 14:20
@daniel-taf daniel-taf force-pushed the daniel.tafoya/e2e-tests-run-in-core branch from 1d6e112 to e4992ca Compare August 23, 2024 19:12
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Aug 23, 2024

[Fast Unit Tests Report]

On pipeline 43079603 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@daniel-taf daniel-taf force-pushed the daniel.tafoya/e2e-tests-run-in-core branch from e4992ca to 717c1cb Compare August 28, 2024 18:07
@daniel-taf daniel-taf changed the title Remove skip from K8s test Add K8s test Aug 28, 2024
@daniel-taf daniel-taf force-pushed the daniel.tafoya/e2e-tests-run-in-core branch from 717c1cb to 93283b5 Compare August 28, 2024 18:11
@daniel-taf daniel-taf added changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation labels Aug 28, 2024
@daniel-taf daniel-taf added this to the 7.58.0 milestone Aug 28, 2024
@daniel-taf daniel-taf changed the title Add K8s test [PROCS-4228] Add E2E tests in K8s for running the process checks in the core agent Aug 28, 2024
@daniel-taf daniel-taf marked this pull request as ready for review August 28, 2024 18:16
@daniel-taf daniel-taf requested a review from a team as a code owner August 28, 2024 18:16
Comment on lines 240 to 243
if findContainer(container, payload.Containers) {
found = true
break
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe instead of logging all payloads, just log the payload that it was found in?

@daniel-taf
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Aug 28, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

@dd-mergequeue dd-mergequeue bot merged commit c81921c into main Aug 28, 2024
211 checks passed
@dd-mergequeue dd-mergequeue bot deleted the daniel.tafoya/e2e-tests-run-in-core branch August 28, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change No code change in Agent code requiring validation team/processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants