-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PROCS-4228] Add E2E tests in K8s for running the process checks in the core agent #28640
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=43079603 --os-family=ubuntu Note: This applies to commit f7f177c |
Regression DetectorRegression Detector ResultsRun ID: 2fbda19a-1aa6-4df0-9576-4f7f22dbfdb4 Metrics dashboard Target profiles Baseline: cbd1883 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | basic_py_check | % cpu utilization | +0.23 | [-2.36, +2.81] | Logs |
➖ | otel_to_otel_logs | ingress throughput | +0.01 | [-0.80, +0.82] | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.00, +0.00] | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | Logs |
➖ | idle | memory utilization | -0.21 | [-0.24, -0.18] | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | -0.24 | [-2.68, +2.19] | Logs |
➖ | file_tree | memory utilization | -0.43 | [-0.49, -0.38] | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -1.15 | [-2.10, -0.20] | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | -3.63 | [-16.51, +9.24] | Logs |
Bounds Checks
perf | experiment | bounds_check_name | replicates_passed |
---|---|---|---|
✅ | idle | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
1d6e112
to
e4992ca
Compare
[Fast Unit Tests Report] On pipeline 43079603 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
e4992ca
to
717c1cb
Compare
717c1cb
to
93283b5
Compare
if findContainer(container, payload.Containers) { | ||
found = true | ||
break | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe instead of logging all payloads, just log the payload that it was found in?
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
Add e2e tests in K8s for running the process checks in the core agent. This also enables the process discovery test as the mentioned issue was fixed.
Motivation
PROCS-4228
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
E2E test passes 😃