Cluster-checks: patch configurations on schedule #2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvello
force-pushed
the
xvello/ccheck-patch-config
branch
from
e893a1f to
5015cef
Compare
Codecov Report
@@ Coverage Diff @@
## master #2862 +/- ##
=========================================
- Coverage 57.4% 57.4% -0.01%
=========================================
Files 392 392
Lines 25616 25662 +46
=========================================
+ Hits 14705 14730 +25
- Misses 9943 9957 +14
- Partials 968 975 +7
|
mfpierre
reviewed
Jan 16, 2019
| func (d *dispatcher) patchConfiguration(in integration.Config) (integration.Config, error) { | ||
| out := in | ||
| out.ADIdentifiers = nil | ||
| out.ClusterCheck = false |
There was a problem hiding this comment.
Why do we do this? Don't we want to be able to identify these? 🤔
There was a problem hiding this comment.
The check collector ignores configurations with that flag. This is needed to avoid having them run in the DCA's collector.
The patching logic is taking a cluster-check configuration and outputting a "classic" check configuration ready to run on a node.
We are able to identify them on the node-agent's configcheck via their source (the clusterchecks config provider), see an example output in https://docs-staging.datadoghq.com/xvello/cchecks/agent/autodiscovery/clusterchecks/#autodiscovery-in-the-node-based-agent
mfpierre
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When configurations enter the clusterchecks dispatcher from the AD, make the following changes:
empty_default_hostnameoption to all instances, so metrics are submitted with no hostnamecluster_nametag in all instancesDoing the modifications here make digests different between the DCA's AD and the clusterchecks logic, but ensure they will be identical between the DCA and the node-agnets, which will be more useful for debugging.
This step of the pipeline has been chosen because this is the earliest point in the pipeline all necessary information is available to batch all required changes in one operation.