-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use only gitlab ReferenceTag instead of UserList #27976
Conversation
@@ -439,18 +438,24 @@ class ReferenceTag(yaml.YAMLObject): | |||
def __init__(self, references): | |||
self.references = references |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was useless before, only the static methods were called
[Fast Unit Tests Report] On pipeline 40206946 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think to remember the initial usage of UserList
was to save creation of the __iter__
and __str__
.
I'm fine with a definition in ReferenceTag, thanks!
Regression DetectorRegression Detector ResultsRun ID: 30c99b42-dd41-4a54-b7d7-872f947b5099 Metrics dashboard Target profiles Baseline: 44bbe07 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | tcp_syslog_to_blackhole | ingress throughput | +4.27 | [-8.82, +17.36] | Logs |
➖ | pycheck_1000_100byte_tags | % cpu utilization | +0.68 | [-4.16, +5.51] | Logs |
➖ | idle | memory utilization | +0.67 | [+0.64, +0.70] | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.00, +0.00] | Logs |
➖ | file_tree | memory utilization | -0.47 | [-0.53, -0.41] | Logs |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | -0.70 | [-1.59, +0.19] | Logs |
➖ | basic_py_check | % cpu utilization | -0.85 | [-3.35, +1.66] | Logs |
➖ | otel_to_otel_logs | ingress throughput | -1.03 | [-1.83, -0.22] | Logs |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
In order to write a
!reference [...]
in a yaml file, we have to useUserList
which is not explicit.Used
ReferenceTag
instead of this and added string representation and a way to iterate through it.No code has to be changed since functions visiting the YAML tree do not need to visit the content of a reference list.
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes