[ASCII-2048] use telemetry component inside the autodiscovery component

[GustavoCaso]

What does this PR do?

Updates the autodiscovery component to use the telemetry component instead of the pkg/telemetry

Motivation

We are moving away from using globals to declare our telemetry metrics

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

• Ensure the telemetry metrics are being emitted as before

[pr-commenter]

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=40217277 --os-family=ubuntu

Note: This applies to commit 1d0674d

[pr-commenter]

Regression Detector

Regression Detector Results

Run ID: a2bcc658-a190-4f82-8d36-858c0ef6f416 Metrics dashboard Target profiles

Baseline: 190d7b8
Comparison: 1d0674d

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	tcp_syslog_to_blackhole	ingress throughput	+4.47	[-8.56, +17.51]	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+2.86	[+1.97, +3.76]	Logs
➖	pycheck_1000_100byte_tags	% cpu utilization	+0.69	[-4.05, +5.43]	Logs
➖	file_tree	memory utilization	+0.36	[+0.29, +0.42]	Logs
➖	idle	memory utilization	+0.15	[+0.12, +0.19]	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	Logs
➖	uds_dogstatsd_to_api	ingress throughput	+0.00	[-0.00, +0.00]	Logs
➖	basic_py_check	% cpu utilization	-0.65	[-3.26, +1.95]	Logs
➖	otel_to_otel_logs	ingress throughput	-1.01	[-1.82, -0.21]	Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[gh123man]

AML owned files LGTM

[GustavoCaso]

/merge

[dd-devflow]

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!

[dd-devflow]

❌ MergeQueue: This merge request has conflicts

This merge request conflicts with another merge request ahead in the queue.

The merge requests in front of this one are:

• #27901 with merge sha fa1f4f6
• #27365 with merge sha 7f99c19

If you need support, contact us on Slack #devflow with those details!

[GustavoCaso]

/merge

[dd-devflow]

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 22m.

Use /merge -c to cancel this operation!