omnibus: fail the task when omnibus can't be installed

[chouquette]

What does this PR do?

Actually fail the task when omnibus can't be installed.

Motivation

We currently continue when omnibus fails to install, which leads to confusing failure later on: https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/578098364

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

[chouquette]

Rerun of the failing pipeline with this commit included: https://gitlab.ddbuild.io/DataDog/datadog-agent/-/jobs/578140216

[alopezz]

I would appreciate adding a test to https://github.com/DataDog/datadog-agent/blob/chouquette/fail_install_omnibus/tasks/unit_tests/omnibus_tests.py though I admit it's not super straightforward.

[agent-platform-auto-pr]

[Fast Unit Tests Report]

On pipeline 39647000 (CI Visibility). The following jobs did not run any unit tests:

Jobs:

• tests_deb-arm64-py3
• tests_deb-x64-py3
• tests_flavor_dogstatsd_deb-x64
• tests_flavor_heroku_deb-x64
• tests_flavor_iot_deb-x64
• tests_rpm-arm64-py3
• tests_rpm-x64-py3
• tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

[pr-commenter]

Regression Detector

Regression Detector Results

Run ID: 9839500d-2d63-4279-b4a2-b889354ed7b4 Metrics dashboard Target profiles

Baseline: bec830a
Comparison: c8f9dc6

Performance changes are noted in the perf column of each table:

• ✅ = significantly better comparison variant performance
• ❌ = significantly worse comparison variant performance
• ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf	experiment	goal	Δ mean %	Δ mean % CI	links
➖	file_tree	memory utilization	+0.57	[+0.50, +0.64]	Logs
➖	otel_to_otel_logs	ingress throughput	+0.53	[-0.29, +1.34]	Logs
➖	idle	memory utilization	+0.48	[+0.44, +0.51]	Logs
➖	uds_dogstatsd_to_api_cpu	% cpu utilization	+0.34	[-0.55, +1.22]	Logs
➖	tcp_dd_logs_filter_exclude	ingress throughput	+0.00	[-0.01, +0.01]	Logs
➖	uds_dogstatsd_to_api	ingress throughput	-0.00	[-0.00, +0.00]	Logs
➖	tcp_syslog_to_blackhole	ingress throughput	-0.14	[-12.94, +12.66]	Logs
➖	pycheck_1000_100byte_tags	% cpu utilization	-0.22	[-5.03, +4.60]	Logs
➖	basic_py_check	% cpu utilization	-1.09	[-3.63, +1.46]	Logs

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

3. Its configuration does not mark it "erratic".

[chouquette]

I would appreciate adding a test to https://github.com/DataDog/datadog-agent/blob/chouquette/fail_install_omnibus/tasks/unit_tests/omnibus_tests.py though I admit it's not super straightforward.

Done, and it allowed me to spot another failure we were silent ly ignoring 🥳

[alopezz]

Thanks for the tests! Can you take a look at the suggested simplification for the exception-related assertions?

[chouquette]

/merge

[dd-devflow]

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!

[chouquette]

/merge --cancel

[dd-devflow]

⚠️ MergeQueue: This merge request build was cancelled

This merge request build was cancelled

If you need support, contact us on Slack #devflow!

[chouquette]

cancelling since the CI is currently failing systematically

[chouquette]

/merge

[dd-devflow]

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 23m.

Use /merge -c to cancel this operation!